Remove unneeded config variable from host (un)install (closes #505)#515
Merged
BigRoy merged 1 commit intogetavalon:masterfrom Jan 24, 2020
Merged
Remove unneeded config variable from host (un)install (closes #505)#515BigRoy merged 1 commit intogetavalon:masterfrom
config variable from host (un)install (closes #505)#515BigRoy merged 1 commit intogetavalon:masterfrom
Conversation
Contributor
Author
|
@BigRoy @davidlatwe Any reason not to merge this? Should somebody else also have a look at it? |
Collaborator
|
Sorry - bit busy. I'm expecting this is all good looking at the code. Since this has seen some signs of approval I'll merge it right away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Removed the config variable from the
host.installandhost.uninstallfunctions. They were still expected, but not used anymore. After #501 was merged, host integrations don't need to care about the config anymore.