Fix #492: Resolve CI coverage bug#494
Conversation
|
For unknown reason, coverage report was able to submit from my fork build, but always failed in PR build. At first I thought there were something broken due to the change in this PR, but turns out it looks like all previous PRs were actually did not submit coverage report successfully, (see here and compare the error code from this PR build here), they just got ignored. And maybe that's why the coveralls badge in README is showing 📞 @mottosso , could it be possible that you need to some how update or turning on-off repo in coveralls.io ? |
|
Is this related to the coverage badge linking to a 404 page altogether? |
|
Yeah, could be related 🕵️♂️ |
|
|
||
| ENTRYPOINT \ | ||
| PYTHONPATH=$(pwd):$PYTHONPATH mayapy -u run_maya_tests.py && \ | ||
| mayapy -c "import sys, os, coveralls;coveralls.wear() if os.getenv('TRAVIS_JOB_ID') else sys.stdout.write('Skipping coveralls')" |
There was a problem hiding this comment.
You're removing some critical information here. Travis needs that ID from the environment, which I've put into the Travis backend environment for passing into it like this.
Could we not keep the command as-is?
There was a problem hiding this comment.
Could we not keep the command as-is?
Sadly we couldn't. :(
The interface of python-coveralls was different from coveralls package, coveralls does not have wear function exposed.
And since I have added TRAVIS=1 into environment, so the job id should be able to pick up from here and then here. Which it did work on my fork build, see here :
Submitting coverage to coveralls.io...
Coverage submitted!
Job #158.1
https://coveralls.io/jobs/56927382
I have also tested with another branch that only pin python-coveralls version, and it also able to send report, see here :
INFO:coveralls:200
INFO:coveralls:{"message":"Job #160.1","url":"https://coveralls.io/jobs/57015951"}
Tricky CI 🤕
3 participants
What's changed ?
This PR resolve #492 and unpinned
sphinx==1.7.9(Since #338)