Skip to content

Conversation

@huard
Copy link
Collaborator

@huard huard commented Sep 19, 2022

Overview

Moves the Sleep process class definition with other test processes to facilitate reuse.

Related Issue / Discussion

In response to comments in #657

Additional Information

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
  • I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

…esses/__init__.py where other test processes are to facilitate reuse.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 81.087% when pulling 53ba8ac on huard:refactor_sleep_test into 85ca819 on geopython:main.

Copy link
Collaborator

@gschwind gschwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Look good to me, maybe I will use Sleep._handler instead of self._handler but it's fine like it.

I did look at code and run pytest in my environment for this review.

Best regards.

@huard huard requested a review from cehbrecht October 19, 2022 17:45
@cehbrecht cehbrecht merged commit 2c884da into geopython:main Jan 27, 2023
@cehbrecht
Copy link
Collaborator

@huard looks good. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants