-
Notifications
You must be signed in to change notification settings - Fork 117
OGC API - Processes: BoundingBox, Complex and reference Input/Output + tests #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c435c3c to
654233a
Compare
…m loaded via a reference
…(GeoJSON), In Reference (GeoJSON)
|
@cehbrecht I tried to support GeoJSON input also inline inside the request and also via a reference. I stumbled upon the problem that if I used a reference then the data inside the ComplexInput is represented as a string (which we need to apply json.loads(s) to get the dict), whereas if I insert the data inline then the data insde the ComplexInput is a dict. Trying to preserve maximum backwards compatibility, i.e not to break usage like: I eventually inserted the json.loads logic inside the data_as_json function: c054817#diff-1504dae61cda8378b070b94031958e8f3a2c954f16959a33876f9411ec249409R323 Do you have a more elegant way for doing so? I think otherwise this PR is ready, and I'd be happy if it can make it into v4.5. |
|
Please review |
|
@idanmiara Looks good to me :) We can look at improvements later on. I have another PR in the pipeline before making 4.5 release. |
|
Thanks @cehbrecht! |
* update changelog * Bump version: 4.4.4 → 4.5.0 * update with ogcapi bbox p4 #614 Co-authored-by: Pingu Carsti <[email protected]>
Overview
This fix add support for BoundingBox, Complex inputs/outputs and extend the relevant docs + tests.
Related Issue / Discussion
v4.5.0 release #613
main implementation #588
docs #612
Contribution Agreement
(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)