fix: make Codex browse runtime work on Windows#797
Open
49EHyeon42 wants to merge 1 commit intogarrytan:mainfrom
Open
fix: make Codex browse runtime work on Windows#79749EHyeon42 wants to merge 1 commit intogarrytan:mainfrom
49EHyeon42 wants to merge 1 commit intogarrytan:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server.tson Windows when the Node bundle path is usednode_modulesin the Codex runtime root so the Windows Node bundle can resolve runtime depsfind-browseto locatebrowse.exe/find-browse.exeon WindowsRepro
git clone --single-branch --depth 1 https://github.com/garrytan/gstack.git ~/gstackcd ~/gstack && ./setup --host codex~/.codex/skills/gstack/browse/dist/browse statuscli.tsresolvesserver.tseagerly even on Windowsbrowse/distbut notnode_modulesfind-browseonly looks forbrowse, notbrowse.exeFix
SERVER_SCRIPTlazy on Windows so the Node path does not requirebrowse/src/server.tsnode_modulesinto~/.codex/skills/gstacksoserver-node.mjscan resolveplaywright/diff.exebinaries in the Windows locator / shim pathsValidation
bun test browse/test/config.test.ts browse/test/find-browse.test.tsserver.ts/server-node.mjspath resolution