Fix mamba version #6560
Open
Fix mamba version #6560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lldelisle
requested review from
bgruening,
hexylena,
martenson,
mira-miracoli and
natefoo
as code owners
Collaborator
|
Thank you @lldelisle This probably needs knitting and testing |
Contributor
bernt-matthias
left a comment
bernt-matthias
left a comment
There was a problem hiding this comment.
I think it is correct as it is, or?
| > `miniconda_prefix` | {% raw %}`"{{ galaxy_tool_dependency_dir }}/_conda"`{% endraw %} | We will manually install conda as well. Normally Galaxy will attempt to auto-install this, but since we will set up a production-ready instance with multiple handlers, there is the chance that they can become deadlocked. | ||
| > `miniconda_version` | `25.3` | Install a specific miniconda version, the latest one at the time of writing that was tested and working. | ||
| > `miniconda_distribution` | `miniforge` | Install a specific distribution of conda, see https://github.com/galaxyproject/ansible-miniconda for alternatives. This determines the default value for the `miniconda_executable` (`conda` for `miniforge`) | ||
| > `miniconda_version` | `2.4.0` | Install a specific miniconda version, the latest one at the time of writing that was tested and working. |
Contributor
There was a problem hiding this comment.
The default conda distribution (confusingly called miniconda_distribution) seems to be miniforge. miniconda_version defaults to latest. Recent version numbers seem to be 25.x: https://github.com/conda-forge/miniforge/releases
Collaborator
Author
There was a problem hiding this comment.
- I agree that the default is miniforge.
- The associated executable is "mamba": https://github.com/galaxyproject/ansible-miniconda/blob/0b2ec2da7d143717b1f21baf15263adca1cc3fb7/defaults/main.yml#L161-L162
- For the version, I tried on my instance
miniconda_version: 25.3and I got an error.
What the role is doing is:
https://github.com/galaxyproject/ansible-miniconda/blob/0b2ec2da7d143717b1f21baf15263adca1cc3fb7/tasks/update.yml#L5-L8
And the last version of mamba is 2.4.0
| > `miniconda_version` | `25.3` | Install a specific miniconda version, the latest one at the time of writing that was tested and working. | ||
| > `miniconda_distribution` | `miniforge` | Install a specific distribution of conda, see https://github.com/galaxyproject/ansible-miniconda for alternatives. This determines the default value for the `miniconda_executable` (`conda` for `miniforge`) | ||
| > `miniconda_version` | `2.4.0` | Install a specific miniconda version, the latest one at the time of writing that was tested and working. | ||
| > `miniconda_distribution` | `miniforge` | Install a specific distribution of conda, see https://github.com/galaxyproject/ansible-miniconda for alternatives. This determines the default value for the `miniconda_executable` (`mamba` for `miniforge`) |
Contributor
There was a problem hiding this comment.
Maybe we can note that miniforge is the default anyway.
FYI: to my knowledge, nowadays there are only minor differences between conda and mamba anyway and according to @bgruening mamba is dead...
Member
There was a problem hiding this comment.
Yes, mamba is dead, please use conda.
(The new cool kid in town is pixi, but I don't think we want to switch, we wait until conda has taken all the pixi advantages ;))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #6518 by @bernt-matthias
I fixed the version to be compatible with mamba.
And changed something in the help text. @bernt-matthias I reverted one of you change, can you check if I am correct?