Skip to content

Conversation

@itisAliRH
Copy link
Member

This PR fixes the vue tsc buffer error (e.g. https://github.com/galaxyproject/galaxy/actions/runs/16675775651/job/47205605676?pr=19658 and https://github.com/galaxyproject/galaxy/actions/runs/16685879675/job/47235076161?pr=20719)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Updates the salt generation function to use the correct buffer reference when converting bytes to a string.
Resolves potential issues with improper data handling during the salt creation process.
Updates the file data conversion to ensure compatibility with the `FormData` API by wrapping the data in a `Uint8Array`.
This resolves potential issues with improper file uploads during API requests.
@itisAliRH itisAliRH marked this pull request as ready for review August 4, 2025 09:25
@github-actions github-actions bot added this to the 25.1 milestone Aug 4, 2025
@itisAliRH
Copy link
Member Author

Failed tests are irrelevant.

@davelopez davelopez merged commit 177b9c9 into galaxyproject:dev Aug 4, 2025
31 of 33 checks passed
@github-actions
Copy link

github-actions bot commented Aug 4, 2025

This PR was merged without a "kind/" label, please correct.

@davelopez davelopez added kind/refactoring cleanup or refactoring of existing code, no functional changes kind/bug labels Aug 4, 2025
@itisAliRH itisAliRH deleted the fix-vue-tsc-buffer-error branch August 4, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/UI-UX kind/bug kind/refactoring cleanup or refactoring of existing code, no functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants