Skip to content

Avoid using displayName as function name since it does not have to be a valid identifier. #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leidegre wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Avoid using displayName as function name since it does not have to be a valid identifier. #59

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab252e8
Avoid using displayName as function name since it does not have to be…
Apr 26, 2016
b5f19b9
We don't need a dynamic function here.
Apr 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions src/createClassProxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,19 +76,10 @@ function proxyClass(InitialComponent) {
}

let displayName = getDisplayName(InitialComponent);
try {
// Create a proxy constructor with matching name
ProxyComponent = new Function('factory', 'instantiate',
`return function ${displayName}() {
return instantiate(factory, this, arguments);
}`
)(() => CurrentComponent, instantiate);
} catch (err) {
// Some environments may forbid dynamic evaluation
ProxyComponent = function () {
return instantiate(() => CurrentComponent, this, arguments);
};
}
ProxyComponent = function DynamicProxyComponent() {
Copy link
Collaborator

@wkwiatek wkwiatek Mar 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some tests to show what problem it solves?

Copy link

@mogelbrod mogelbrod Apr 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's useful for HOCs to wrap the displayName of the base component, for example HigherOrderComponent(BaseComponent). This is not a valid function name however, which causes unnecessary errors to be thrown.

return instantiate(() => CurrentComponent, this, arguments);
};
// Fix-up: the DynamicProxyComponent name should reflect the inner component
try {
Object.defineProperty(ProxyComponent, 'name', {
value: displayName
Expand Down