Fix copies=0 producing wrong VRS object type#621
Merged
korikuzma merged 3 commits intoga4gh:mainfrom Apr 2, 2026
Merged
Conversation
Contributor
Author
|
found this while reading the translator - copies=0 is valid (homozygous deletion) but gets skipped since 0 is falsy in python |
korikuzma
requested changes
Apr 2, 2026
Contributor
korikuzma
left a comment
korikuzma
left a comment
There was a problem hiding this comment.
Great catch! Would you be able to add a test for this issue in test_cnv_translator.py ?
Contributor
Author
|
thanks for the feedback! added a test for it - checks that copies=0 gives back CopyNumberCount and not CopyNumberChange |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copies=0 in _from_hgvs falls through to CopyNumberChange branch
because
if copies:treats 0 as falsy. changed toif copies is not None: