Skip to content

build!: Split dev deps into dev, tests, lint, docs groups#619

Merged
korikuzma merged 3 commits intoga4gh:v3from
knQzx:fix/split-dev-deps-and-model-validator
Apr 2, 2026
Merged

build!: Split dev deps into dev, tests, lint, docs groups#619
korikuzma merged 3 commits intoga4gh:v3from
knQzx:fix/split-dev-deps-and-model-validator

Conversation

@knQzx
Copy link
Copy Markdown
Contributor

@knQzx knQzx commented Mar 24, 2026

split the dev dependency group into test, lint, docs so CI jobs can install only what they need. the dev meta-group still pulls everything in so existing workflows don't break

model validator fix moved to #620 as requested

fixes #608
I emailed you about GSoC 2026 (knqzx0@gmail.com)

CI can now install only what it needs (e.g. pip install .[test])
instead of pulling everything. dev group still works as before
since it references all three.

Fixes ga4gh#608
@knQzx knQzx requested review from a team as code owners March 24, 2026 15:35
Copy link
Copy Markdown
Contributor

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! Would you be able to split this out into two separate PRs - 1 for #608 and 1 for for #618? This will make the commit history clean.

You can keep this one open for whichever you prefer.

@knQzx knQzx force-pushed the fix/split-dev-deps-and-model-validator branch from de8cdd1 to 56e9a29 Compare March 24, 2026 15:43
@knQzx knQzx changed the title Split dev deps and fix model_validator in MappableConcept Split dev deps into test, lint, docs groups Mar 24, 2026
@knQzx
Copy link
Copy Markdown
Contributor Author

knQzx commented Mar 24, 2026

Thank you for this! Would you be able to split this out into two separate PRs - 1 for #608 and 1 for for #618? This will make the commit history clean.

You can keep this one open for whichever you prefer.

Yep, did it, thanks for the feedback!

@knQzx knQzx requested a review from korikuzma March 24, 2026 22:18
Copy link
Copy Markdown
Contributor

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this PR! There are few minor things to be changed and added.

We should update this to use tests instead of dev

pip install -e .[dev,extras]

@knQzx
Copy link
Copy Markdown
Contributor Author

knQzx commented Apr 2, 2026

thanks for the review! renamed to tests, removed the dev meta-group, updated the ci workflow and makefile to use the new groups

Copy link
Copy Markdown
Contributor

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@korikuzma
Copy link
Copy Markdown
Contributor

I think I will change the base branch to be for v3 since this is technically a breaking change.

@korikuzma korikuzma changed the base branch from main to v3 April 2, 2026 19:23
@korikuzma korikuzma changed the title Split dev deps into test, lint, docs groups build!: Split dev deps into dev, tests, lint, docs groups Apr 2, 2026
@korikuzma korikuzma merged commit 0c69104 into ga4gh:v3 Apr 2, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split up dev dependency group

2 participants