Skip to content

feat: add deprecation warning for beacon translation#578

Merged
korikuzma merged 7 commits intomainfrom
issue-568
Oct 15, 2025
Merged

feat: add deprecation warning for beacon translation#578
korikuzma merged 7 commits intomainfrom
issue-568

Conversation

@korikuzma
Copy link
Copy Markdown
Contributor

@korikuzma korikuzma commented Aug 15, 2025

close #568

  • One of the Beacon leads (@mbaudis) requested this to be removed since it does not follow the standard, for now we will add a deprecation message and remove this in v3.
  • Added typing_extensions as an extras dep

close #568

* One of the Beacon leads (@mbaudis) requested this to be removed since it does not follow the standard
@jsstevenson
Copy link
Copy Markdown
Contributor

Strictly speaking, as a breaking change, is this a -> 3.0 release? (or can we 🙈 about it)

@korikuzma
Copy link
Copy Markdown
Contributor Author

Strictly speaking, as a breaking change, is this a -> 3.0 release? (or can we 🙈 about it)

Yes 3.0 release

@ahwagner
Copy link
Copy Markdown
Member

For those that don't want to do major version upgrades–perhaps a related PR that just adds a deprecation warning for the 2.x series? Just not sure when we want to pull the trigger on a major version release, and if there are other features we might want to merge in to something like that.

@korikuzma
Copy link
Copy Markdown
Contributor Author

@ahwagner Deprecation warning makes sense. I don't think we have established release strategy / branch strategies for our reference implementations. I know we've had discussions, but I don't think it's been documented anywhere on what we chose. So we should probably have that discussion.

@jsstevenson
Copy link
Copy Markdown
Contributor

Maybe we could merge an implementation of a deprecation warning now, and merge this PR into a 3.x branch? I think we'd want to assess whether there are other breaking changes we might want to include in a new major version release before we put one out

@korikuzma korikuzma changed the title feat!: remove support for beacon translation feat: add deprecation warning for beacon translation Oct 6, 2025
@korikuzma
Copy link
Copy Markdown
Contributor Author

@ga4gh/vrs-python-maintainers This is ready for review now

@korikuzma korikuzma requested a review from jsstevenson October 6, 2025 12:52
@korikuzma korikuzma merged commit 6c32886 into main Oct 15, 2025
16 checks passed
@korikuzma korikuzma deleted the issue-568 branch October 15, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename & re-engineer misleading "beacon" Translator format

3 participants