Open
Conversation
764ee4e to
6759a3f
Compare
6759a3f to
d7d5a16
Compare
Collaborator
|
Thanks for digging in here. CI tests run against Azurite, which Microsoft updated 6 weeks ago. I'll dig into this failure mode, then I'll circle back to the question of other topics. |
Author
|
Any update on this? |
Author
|
@hayesgb did you find time to look into this? |
Author
|
Anything I can do to get this merged? |
Contributor
|
Any update or progress on this? |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
Please let me know what you think about these changes.
I noticed that _glob_find and _find are not consistent when returning directory paths. _find returns trailing slashes while _glob_find does not. Is that intended?
Also in the current implementation _expand_path includes the root directory for non-glob paths, while _glob_find does not. What is the desired behavior here?
About tests: