Merged
Conversation
Member
Author
|
I'm considering changing the exception type as before ( I'm not really sure to make this because it works as it is right now. What do you think @sergey-tihon? |
Member
|
I think that FsUnit should be as close to the underlying framework (xUnit) as possible. If xUnit throws another exception, we should not wrap it in the custom exception type. It should be a way to understand and use FsUnit if it behaves as an underlying framework. |
Member
Author
|
Good point. |
Member
Author
|
I think this is ready now. @sergey-tihon Do you have any additions? |
sergey-tihon
approved these changes
Jul 11, 2023
abelbraaksma
added a commit
to fsprojects/FSharp.Control.TaskSeq
that referenced
this pull request
Oct 28, 2023
…hedValues`, thanks XUnit for making incompatible changes without first deprecating types See fsprojects/FsUnit#240 for the FsUnit change (2nd commit) and fsprojects/FsUnit#251, and https://xunit.net/releases/v2/2.5.0
abelbraaksma
added a commit
to fsprojects/FSharp.Control.TaskSeq
that referenced
this pull request
Oct 28, 2023
…hedValues`, thanks XUnit for making incompatible changes without first deprecating types See fsprojects/FsUnit#240 for the FsUnit change (2nd commit) and fsprojects/FsUnit#251, and https://xunit.net/releases/v2/2.5.0
abelbraaksma
added a commit
to fsprojects/FSharp.Control.TaskSeq
that referenced
this pull request
Oct 28, 2023
…hedValues`, thanks XUnit for making incompatible changes without first deprecating types See fsprojects/FsUnit#240 for the FsUnit change (2nd commit) and fsprojects/FsUnit#251, and https://xunit.net/releases/v2/2.5.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.