Use hierarchical CSS styles in exported HTML#190
Closed
aryanjsingh wants to merge 1 commit intofrescobaldi:masterfrom
Closed
Use hierarchical CSS styles in exported HTML#190aryanjsingh wants to merge 1 commit intofrescobaldi:masterfrom
aryanjsingh wants to merge 1 commit intofrescobaldi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change modifies the CSS generation for HTML export to use hierarchical styles. Instead of flat class names like
.comment, styles are now nested under a parent selector (e.g.,#document .comment), preventing potential conflicts with other CSS on a webpage.Changes
format_stylesheetto accept aparent_selectorargument and prepend it to generated CSS selectors. UpdatedHtmlWriter.htmlto pass the appropriate parent selector toformat_stylesheet, ensuring that generated CSS styles are hierarchical and scoped to the document container.Related Issue
Closes #44