Skip to content

Comments

86b85g4ct - fix: add buster number to image url to avoid cache issues#765

Merged
smarcet merged 2 commits intomasterfrom
fix/showing_wrong_images_in_item_edit
Feb 4, 2026
Merged

86b85g4ct - fix: add buster number to image url to avoid cache issues#765
smarcet merged 2 commits intomasterfrom
fix/showing_wrong_images_in_item_edit

Conversation

@ghost
Copy link

@ghost ghost commented Jan 30, 2026

ref: https://app.clickup.com/t/86b85g4ct

86b85g4ct - fix: add buster number to image url to avoid cache issues

Changelog

  • Add buster number to image url to avoid cache issues

86b85g4ct - Showing wrong images in Item>Edit

Evidence

image

Summary by CodeRabbit

  • Bug Fixes
    • Sponsor inventory images now include a timestamp parameter so updated images appear immediately in the sponsor inventory popup, avoiding stale cached thumbnails and improving visual consistency.
    • Minor display reliability improvements when opening the sponsor inventory form to ensure current media is shown.

✏️ Tip: You can customize this high-level summary in your review settings.

@ghost ghost requested review from romanetar and smarcet January 30, 2026 15:45
@ghost ghost assigned smarcet, romanetar and ghost Jan 30, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 30, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Appends a timestamp-based cache-busting query parameter (?t=[timestamp]) to image filenames in the sponsor inventory popup media input mapping; data shape and control flow otherwise unchanged.

Changes

Cohort / File(s) Summary
Image cache busting
src/pages/sponsors-global/form-templates/sponsor-inventory-popup.js
Within the getMediaInputValue mapping for initialEntity.images, compute the image filename as before and append ?t=[timestamp] to the filename field returned by the map to force cache-busting. Minor local-variable and return-object changes only.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • romanetar

Poem

🐰
I hop through code with a twitch and a grin,
Appending a timestamp to keep images thin,
No stale sprites in sight,
Each load fresh and bright,
A bunny-approved cache-cleansing spin! 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding a cache-busting query parameter to image URLs to avoid caching issues, which matches the code modification that appends a timestamp-based buster parameter to image filenames.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/showing_wrong_images_in_item_edit

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit 382c527 into master Feb 4, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants