86b7h2jgh - Fix: add asterisks to mandatory fields on add new item form · Pull Request #743 · fntechgit/summit-admin

ghost · 2026-01-05T13:18:53Z

ref: https://app.clickup.com/t/86b7h2jgh

86b7h2jgh - Fix: add asterisks to mandatory fields on add new item form

Changelog

Add asterisks to i18n strings.
Add require yup validation to mandatory fields.

Links

86b7h2jgh - Add asterisks to mandatory fields

Evidence

2026-01-05_10-16-31.mp4

Summary by CodeRabbit

New Features
- Sponsor form fields (name, early bird rate, standard rate, onsite rate, default quantity) now show required-field indicators to clarify mandatory inputs, improving form validation visibility and reducing submission errors.
- Shared text input component now supports marking fields as required and displays an asterisk on labels for consistent required-field UX across the app, ensuring uniform behavior and clearer prompts.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

smarcet · 2026-01-19T20:03:29Z

src/i18n/en.json

-    "standard_rate": "Standard rate",
-    "onsite_rate": "On site rate",
-    "default_quantity": "Default quantity",
+    "name": "Name *",


@niko-exo i do thnk that i would be better to update the fields like
https://github.com/fntechgit/summit-admin/blob/cf8c1749e92a5c08b60bf5803010a63e9417e5d0/src/components/mui/formik-inputs/mui-formik-textfield.js to support the required attr instead of change labels

I've removed the asterisks and modified the text field to have the same logic as te datepicker.

smarcet · 2026-01-19T20:04:55Z

src/pages/sponsors/sponsor-form-item-list-page/components/item-form.js

-      early_bird_rate: decimalValidation(),
-      standard_rate: decimalValidation(),
-      onsite_rate: decimalValidation(),
+      early_bird_rate: decimalValidation().required(


@niko-exo please rebase against main and review
we already addd required to decimal validation

smarcet · 2026-01-19T20:05:33Z

src/pages/sponsors/sponsor-form-item-list-page/components/item-form.js

+      onsite_rate: decimalValidation().required(
+        T.translate("validation.required")
+      ),
      default_quantity: numberValidation()


@niko-exo also please check this
default_quantity: positiveNumberValidation(),
quantity_limit_per_sponsor: positiveNumberValidation(),
quantity_limit_per_show: positiveNumberValidation(),
meta_fields: formMetafieldsValidation()

smarcet

@niko-exo please review comments

ghost · 2026-01-21T12:56:31Z

Branch rebased

coderabbitai · 2026-01-21T12:56:42Z

📝 Walkthrough

Walkthrough

Added a required prop to the reusable MuiFormikTextField so labels can show an asterisk; updated the sponsor form to pass required for name, early_bird_rate, standard_rate, onsite_rate, and default_quantity fields to mark them mandatory in the UI.

Changes

Cohort / File(s)	Summary
Form component `src/components/mui/formik-inputs/mui-formik-textfield.js`	Added `required` prop (default false); compute `finalLabel` and render it so label shows `" *"` when required. Updated PropTypes.
Sponsor form fields `src/pages/sponsors/sponsor-form-item-list-page/components/sponsor-form-item-form.js`	Passed `required` to fields: `name`, `early_bird_rate`, `standard_rate`, `onsite_rate`, `default_quantity` to display required indicators.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

smarcet

Poem

A rabbit hops through lines of code,
Adds tiny stars along the road,
Fields now sparkle, tidy, bright,
Guiding users through the night,
✨🐇

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: adding asterisks to mandatory fields in the add new item form, which aligns with the PR's core objective of improving UX for required form fields.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

🤖 Fix all issues with AI agents

In `@src/i18n/en.json`:
- Around line 2579-2583: Remove the trailing asterisks from the base keys
sponsor_form_item_list.name, sponsor_form_item_list.early_bird_rate,
sponsor_form_item_list.standard_rate, sponsor_form_item_list.onsite_rate, and
sponsor_form_item_list.default_quantity and add those asterisks to the
corresponding edit form keys: sponsor_form_item_list.edit_item.name,
sponsor_form_item_list.edit_item.early_bird_rate,
sponsor_form_item_list.edit_item.standard_rate,
sponsor_form_item_list.edit_item.onsite_rate, and
sponsor_form_item_list.edit_item.default_quantity so the add/edit form uses the
translated labels with asterisks while the table headers remain plain.

In
`@src/pages/sponsors/sponsor-form-item-list-page/components/sponsor-form-item-form.js`:
- Around line 76-80: positiveNumberValidation() in utils/yup.js is missing
.required(), so fields using it (default_quantity, quantity_limit_per_sponsor,
quantity_limit_per_show) are allowed empty despite UI requiring them; update
positiveNumberValidation() to include .required() (like decimalValidation()
does) and keep the existing positive/number constraints so those three form
fields are validated as required and non-negative integers.

coderabbitai · 2026-01-21T13:02:16Z

src/i18n/en.json

+    "name": "Name *",
+    "early_bird_rate": "Early bird rate *",
+    "standard_rate": "Standard rate *",
+    "onsite_rate": "On site rate *",
+    "default_quantity": "Default quantity *",


⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

rg -n -C2 'sponsor_form_item_list\.(name|early_bird_rate|standard_rate|onsite_rate|default_quantity)\b' -g '!**/node_modules/**'

Repository: fntechgit/summit-admin

Length of output: 2285

🏁 Script executed:

rg -n -C2 'sponsor_form_item_list\.edit_item\.(name|early_bird_rate|standard_rate|onsite_rate|default_quantity)\b' -g '!**/node_modules/**'

Repository: fntechgit/summit-admin

Length of output: 3203

Update asterisks to the correct translation keys for the add/edit form.

The asterisks were added to sponsor_form_item_list.* (table column headers), but the add/edit form uses sponsor_form_item_list.edit_item.* keys instead. The asterisks will not appear in the form. Move them to:

sponsor_form_item_list.edit_item.name

sponsor_form_item_list.edit_item.early_bird_rate

sponsor_form_item_list.edit_item.standard_rate

sponsor_form_item_list.edit_item.onsite_rate

sponsor_form_item_list.edit_item.default_quantity

Remove asterisks from the base keys (lines 2579-2583) since they are used only for table headers.

🤖 Prompt for AI Agents

In `@src/i18n/en.json` around lines 2579 - 2583, Remove the trailing asterisks from the base keys sponsor_form_item_list.name, sponsor_form_item_list.early_bird_rate, sponsor_form_item_list.standard_rate, sponsor_form_item_list.onsite_rate, and sponsor_form_item_list.default_quantity and add those asterisks to the corresponding edit form keys: sponsor_form_item_list.edit_item.name, sponsor_form_item_list.edit_item.early_bird_rate, sponsor_form_item_list.edit_item.standard_rate, sponsor_form_item_list.edit_item.onsite_rate, and sponsor_form_item_list.edit_item.default_quantity so the add/edit form uses the translated labels with asterisks while the table headers remain plain.

coderabbitai · 2026-01-21T13:02:16Z

src/pages/sponsors/sponsor-form-item-list-page/components/sponsor-form-item-form.js

                name="name"
                label={T.translate("sponsor_form_item_list.edit_item.name")}
                fullWidth
+                required
              />


⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash # Find yup utility files find src -type f \( -name '*yup*' -o -name '*validation*' \) | head -20

Repository: fntechgit/summit-admin

Length of output: 82

🏁 Script executed:

cat -n src/utils/yup.js

Repository: fntechgit/summit-admin

Length of output: 6358

🏁 Script executed:

cat -n src/pages/sponsors/sponsor-form-item-list-page/components/sponsor-form-item-form.js | head -200

Repository: fntechgit/summit-admin

Length of output: 7438

Only positiveNumberValidation() lacks required enforcement; decimalValidation() already has it.

The form uses noValidate, so native HTML5 checks are disabled. However, the issue is narrower than stated: decimalValidation() (line 45-54 in utils/yup.js) already includes .required() on line 50, so early_bird_rate, standard_rate, and onsite_rate are properly validated.

The actual problem is positiveNumberValidation() (line 90-93 in utils/yup.js) does not include .required(). This means default_quantity (line 152), quantity_limit_per_sponsor, and quantity_limit_per_show can pass validation even when empty, despite the UI marking them required or accepting empty values.

Required fix

export const positiveNumberValidation = () => numberValidation() .integer(T.translate("validation.integer")) - .min(0, T.translate("validation.number_positive")); + .required(T.translate("validation.required")) + .min(0, T.translate("validation.number_positive"));

🤖 Prompt for AI Agents

In `@src/pages/sponsors/sponsor-form-item-list-page/components/sponsor-form-item-form.js` around lines 76 - 80, positiveNumberValidation() in utils/yup.js is missing .required(), so fields using it (default_quantity, quantity_limit_per_sponsor, quantity_limit_per_show) are allowed empty despite UI requiring them; update positiveNumberValidation() to include .required() (like decimalValidation() does) and keep the existing positive/number constraints so those three form fields are validated as required and non-negative integers.

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@src/components/mui/formik-inputs/mui-formik-textfield.js`:
- Around line 6-10: The component builds finalLabel by concatenating required to
label, which can produce "undefined *" when label is missing; update the
MuiFormikTextField logic (around finalLabel) to guard for empty/undefined label
by using a safe default or conditional concat (e.g., only append " *" when label
is truthy, or derive finalLabel from label ?? '' and then append the required
marker), ensuring finalLabel never becomes "undefined *" while preserving
required behavior.

🧹 Nitpick comments (1)

src/components/mui/formik-inputs/mui-formik-textfield.js (1)
14-22: Add semantic required to TextField (a11y) and avoid double indicators.
Right now required only affects the label string. Consider passing required={required} so the input is semantically required (ARIA/HTML). If you keep the manual " *" suffix, suppress MUI’s built‑in asterisk to avoid duplication.
🛠️ Suggested tweak (verify MUI behavior)
       <TextField
         name={name}
         label={finalLabel}
+        required={required}
+        InputLabelProps={{ required: false }}
         {...field}
 MuiFormikTextField.propTypes = {
   name: PropTypes.string.isRequired,
   label: PropTypes.string,
-  maxLength: PropTypes.number
+  maxLength: PropTypes.number,
+  required: PropTypes.bool
 };

ghost · 2026-01-21T13:28:25Z

Ready for review!

smarcet · 2026-01-21T13:34:08Z

src/components/mui/formik-inputs/mui-formik-textfield.js

  const [field, meta] = useField(name);
  const currentLength = field.value?.length || 0;

+  const finalLabel = required ? `${label} *` : label;


@niko-exo label attribute is marked as not required
please add a check and set finalLabel as empty to avoid "* undefined"

Fixed. Good catch!

smarcet · 2026-01-21T13:34:51Z

src/components/mui/formik-inputs/mui-formik-textfield.js

 import { useField } from "formik";

-const MuiFormikTextField = ({ name, label, maxLength, ...props }) => {
+const MuiFormikTextField = ({ name, label, maxLength, required, ...props }) => {


@niko-exo please add requred to prop types and define it with default value as false

smarcet

@niko-exo please review comments

ghost · 2026-01-21T14:43:10Z

Ready for review!

smarcet

LGTM

ghost requested a review from smarcet January 5, 2026 13:18

ghost assigned smarcet and ghost Jan 5, 2026

smarcet reviewed Jan 19, 2026

View reviewed changes

smarcet requested changes Jan 19, 2026

View reviewed changes

Nicolas Olmos added 2 commits January 21, 2026 09:35

fix: add asterisks to field label

6306a68

fix: add yup validations to mandatory fields

8c05d2f

ghost force-pushed the fix/add-asterisks branch from 9f6d2bd to 8c05d2f Compare January 21, 2026 12:56

coderabbitai bot reviewed Jan 21, 2026

View reviewed changes

Nicolas Olmos added 2 commits January 21, 2026 10:02

chore: delete asterisk from i18n file

c398d26

chore: add required label logic to text field

9e8be0e

coderabbitai bot reviewed Jan 21, 2026

View reviewed changes

smarcet reviewed Jan 21, 2026

View reviewed changes

fntechgit deleted a comment from coderabbitai bot Jan 21, 2026

smarcet reviewed Jan 21, 2026

View reviewed changes

smarcet requested changes Jan 21, 2026

View reviewed changes

Nicolas Olmos added 2 commits January 21, 2026 11:30

chore: validate label existance before adding an asterisk if required

44c1f36

chore: add default value and prop type for required prop

e3006de

ghost requested a review from smarcet January 21, 2026 15:01

smarcet approved these changes Jan 21, 2026

View reviewed changes

smarcet merged commit ad28403 into master Jan 21, 2026
9 checks passed

coderabbitai bot mentioned this pull request Jan 22, 2026

86b883b71 - Add Numeric Validation for Quantities Fields #761

Merged

coderabbitai bot mentioned this pull request Feb 5, 2026

fix: add missing asterisks for rate fields on popups #782

Merged

Conversation

ghost commented Jan 5, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

86b7h2jgh - Fix: add asterisks to mandatory fields on add new item form

Changelog

Links

Evidence

Summary by CodeRabbit

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smarcet left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Jan 21, 2026

Uh oh!

coderabbitai bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Suggested reviewers

Poem

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Jan 21, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smarcet left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Jan 21, 2026

Uh oh!

smarcet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ghost commented Jan 5, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 21, 2026 •

edited

Loading