86b7yxuzh - fix: close modal on succesful approval#742
Merged
Conversation
added 4 commits
December 31, 2025 14:41
smarcet
reviewed
Jan 13, 2026
| fetchResponseHandler, | ||
| fetchErrorHandler | ||
| } from "openstack-uicore-foundation/lib/utils/actions"; | ||
| import * as _ from "lodash"; |
Signed-off-by: sebastian marcet <smarcet@gmail.com>
|
LGTM |
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughLodash imports are migrated from default to namespace syntax across three action files. A new test suite with comprehensive mock data is added for the ProcessRequestPopup component. The component's save handler is made asynchronous to await sponsor user request processing before closing the dialog. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related PRs
Poem
✨ Finishing touches
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86b7yxuzh
86b7yxuzh - fix: close modal on succesful approval
Changelog
Link
86b7yxuzh - Sponsor users - Show Level - Access Request Approval - Modal should be closed after a successful approval
Evidence
2025-12-31_14-35-51.mp4
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.