Allow clients to fetch all cookies including HttpOnly.#773
Open
ftore wants to merge 2 commits intofluttercommunity:masterfrom
Open
Allow clients to fetch all cookies including HttpOnly.#773ftore wants to merge 2 commits intofluttercommunity:masterfrom
ftore wants to merge 2 commits intofluttercommunity:masterfrom
Conversation
…ng httponly ones. Current getCookies() method doesn't return httponly cookies such as SESSION.
|
@fluttercommunity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation of
getCookiesuses javascriptdocument.cookieto get cookies. However , it doesn't return HttpOnly cookies which can be set server side. The reason for this is javascript doesn't have access to HttpOnly cookies. This PR contains addition method calledgetAllCookiesthat return all cookies that has beed set.This PR is the slight modification of this one which also fixes all the conflicts: #608
Discussion for this PR is here: #336