Add first version of flutter.io/docs#817
Merged
filiph merged 5 commits intoflutter:masterfrom Feb 27, 2018
Merged
Conversation
This will be the “index” of our docs (as the homepage will lack sidenav pretty soon).
googlebot
added
the
cla: yes
Contributor
|
This seems great! ...But, can I see it staged? |
Contributor
|
One downside is that it will now require 2 clicks instead of 1 to get to API docs from any page on flutter.io, since it's no long part of the top navigation. We should track how this change affects API doc usage. |
sethladd
reviewed
Feb 26, 2018
sethladd
reviewed
Feb 26, 2018
| * [Flutter Widget Inspector](/inspector/) | ||
| The Flutter Inspector, a tool available in the Flutter plugin for your IDE. | ||
|
|
||
| |
Contributor
Author
There was a problem hiding this comment.
Yes. This is because there is not enough space between ul and headers.
The implementation is ugly but the special-case CSS would be even uglier. When I have time, I'll see if changing the CSS everywhere to give more margin between ul and h2 won't break some page somewhere.
filiph
changed the title
Contributor
Author
|
Alright, I fixed the example link, and confirmed we're not breaking any other links. I think I'll merge. |
The URLs worked, but: * /setup is redirected to /get-started/install/, so let’s use the final destination itself * let’s use URLs with trailing slash, as that seems to be the canonical way on flutter.io
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be the “index” of our docs (as the homepage will lack sidenav pretty soon).