FFI plugin docs#7111
Merged
khanhnwin merged 5 commits intoflutter:mainfrom May 11, 2022
mit-mit:pluginffi
Merged
Conversation
mit-mit
requested review from
domesticmouse,
johnpryan,
khanhnwin and
sfshaza2
as code owners
domesticmouse
approved these changes
May 11, 2022
parlough
reviewed
May 11, 2022
Member
parlough
left a comment
parlough
left a comment
There was a problem hiding this comment.
This looks great, I just have some minor comments/questions.
Also do we have a FFI plugin sample we could point to?
Co-authored-by: Parker Lougheed <parlough@gmail.com>
Member
Author
I'm afraid not currently. |
parlough
approved these changes
May 11, 2022
Member
parlough
left a comment
parlough
left a comment
There was a problem hiding this comment.
Thanks for the updates, looks good to me :)
You may have to reopen/update the PR once @khanhnwin incorporates the WIP website changes.
Co-authored-by: Parker Lougheed <parlough@gmail.com>
johnpryan
approved these changes
May 11, 2022
Contributor
|
Fix for stable build is part of #7113 . Once that's merged in, we can merge from main into this branch and it should pass the build. |
khanhnwin
approved these changes
May 11, 2022
Member
Author
|
@khanhnwin can you help ensuring this gets merged when ready? It's nearly midnight here, so I'm heading out shortly... |
Contributor
|
@mit-mit Will do! |
Contributor
|
Merged! Thanks @mit-mit! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7073