Skip to content

Update screenshots to Xcode 13#6287

Merged
sfshaza2 merged 1 commit intoflutter:mainfrom
jmagman:xcode-images
Sep 16, 2021
Merged

Update screenshots to Xcode 13#6287
sfshaza2 merged 1 commit intoflutter:mainfrom
jmagman:xcode-images

Conversation

@jmagman
Copy link
Copy Markdown
Member

@jmagman jmagman commented Sep 16, 2021

  • Update screenshots to show newest version of Xcode, and iOS 9 instead of iOS 8 (see Update iOS minimum version to 9.0 #6057). Ran npx gulp compress-images on all updated images.
  • Replace references to Xcode 11.4 (which is no longer supported) to either "Xcode" or "Xcode 11.4 and higher".
  • Fix reference to ios to macos in macOS setup instructions.

Before:
macos_xcode_settings

After:
macos_xcode_settings

Before:
xcode_settings

After:
xcode_settings

Before:
xcode-account

After:
xcode-account

Before:
xcode-unique-bundle-id

After:
xcode-unique-bundle-id

Before:
ios-launchscreen-xcode

After:
ios-launchscreen-xcode

@jmagman jmagman added the iOS label Sep 16, 2021
@jmagman jmagman self-assigned this Sep 16, 2021
@google-cla google-cla bot added the cla: yes Contributor has signed the Contributor License Agreement label Sep 16, 2021
sfshaza2
sfshaza2 approved these changes Sep 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @jmagman!

@jmagman
Copy link
Copy Markdown
Member Author

jmagman commented Sep 16, 2021

  • Fix reference to ios to macos in macOS setup instructions.

@sfshaza2 the src/docs/deployment/macos.md instructions aren't linked in the sidenav. Is that intentional?
Screen Shot 2021-09-16 at 12 10 15 PM
https://flutter.dev/docs/deployment/macos

/cc @cbracken

@sfshaza2
Copy link
Copy Markdown
Contributor

sfshaza2 commented Sep 16, 2021

No, @jmagman, definitely not intentional! Thanks for catching that. We have "lost" several pages from the sidebar when we migrated to the dockerized version of the website. I can file a PR unless you want to? (I'm assuming not.)

@sfshaza2 sfshaza2 merged commit c4da6b0 into flutter:main Sep 16, 2021
@jmagman jmagman deleted the xcode-images branch September 16, 2021 19:53
@jmagman
Copy link
Copy Markdown
Member Author

jmagman commented Sep 16, 2021

No, @jmagman, definitely not intentional! Thanks for catching that. We have "lost" several pages from the sidebar when we migrated to the dockerized version of the website. I can file a PR unless you want to? (I'm assuming not.)

Created #6288

@Coronon Coronon mentioned this pull request Oct 19, 2021
Closed
@atsansone atsansone added os:ios and removed iOS labels Sep 30, 2022
@atsansone atsansone added target.iOS Target apps on the iOS Platform and removed os:iOS labels May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@domesticmouse domesticmouse Awaiting requested review from domesticmouse

@johnpryan johnpryan Awaiting requested review from johnpryan

@kwalrath kwalrath Awaiting requested review from kwalrath

@redbrogdon redbrogdon Awaiting requested review from redbrogdon

Assignees

@jmagman jmagman

Labels

cla: yes Contributor has signed the Contributor License Agreement target.iOS Target apps on the iOS Platform

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @sfshaza2 @atsansone