Skip to content

Correct spelling of Xcode in integration test instructions#6106

Merged
sfshaza2 merged 1 commit intoflutter:masterfrom
jmagman:xcode-spelling
Aug 6, 2021
Merged

Correct spelling of Xcode in integration test instructions#6106
sfshaza2 merged 1 commit intoflutter:masterfrom
jmagman:xcode-spelling

Conversation

@jmagman
Copy link
Copy Markdown
Member

@jmagman jmagman commented Aug 6, 2021

Introduced in #5954.

@jmagman jmagman requested a review from johnpryan August 6, 2021 02:01
@jmagman jmagman requested a review from kwalrath as a code owner August 6, 2021 02:01
@jmagman jmagman self-assigned this Aug 6, 2021
@google-cla google-cla bot added the cla: yes Contributor has signed the Contributor License Agreement label Aug 6, 2021
Copy link
Copy Markdown
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks for keeping us honest!

@sfshaza2 sfshaza2 merged commit cc3e3a6 into flutter:master Aug 6, 2021
@jmagman jmagman deleted the xcode-spelling branch August 6, 2021 20:50
@jmagman
Copy link
Copy Markdown
Member Author

jmagman commented Aug 6, 2021

LGTM. thanks for keeping us honest!

I couldn't find how https://github.com/flutter/website/blob/master/.spelling is used or if it's used, but there doesn't seem to be a way in that kind of config file to make suggestions XCode->Xcode, it seems you can only add exceptions?

@johnpryan
Copy link
Copy Markdown
Contributor

I think .spelling was added by accident in 2714d9f - it doesn't look like any of our site infrastructure uses it

@johnpryan
Copy link
Copy Markdown
Contributor

johnpryan commented Aug 6, 2021

I filed an issue for the .spelling file: #6109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants