Skip to content

Showcase redesign#3034

Merged
sfshaza2 merged 2 commits intoflutter:masterfrom
1Iv4N:master
Sep 26, 2019
Merged

Showcase redesign#3034
sfshaza2 merged 2 commits intoflutter:masterfrom
1Iv4N:master

Conversation

@1Iv4N
Copy link
Copy Markdown
Contributor

@1Iv4N 1Iv4N commented Sep 25, 2019

[b/141305122] Showcase redesign.

What's included?

  • New showcase page.
  • Cleanup styles and assets from the previous version.

GomezMimo and others added 2 commits September 25, 2019 17:42
[b/141305122] Showcase redesign.

What's included?
- New showcase page.
- Cleanup styles and assets from the previous version.
[b/141305122] Showcase redesign.

What's included?
- Optimize carousel SVG background texture.
- Optimize logos.
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Contributor has not signed the Contributor License Agreement label Sep 25, 2019
@1Iv4N
Copy link
Copy Markdown
Contributor Author

1Iv4N commented Sep 25, 2019

@googlebot I signed it!

@maguinis maguinis requested a review from sfshaza2 September 26, 2019 00:44
@sfshaza2
Copy link
Copy Markdown
Contributor

@1Iv4N, can you provide me with the URL for a staged version of the site? If you'd rather not put it in this PR, just email or IM it to me. Thx

@1Iv4N
Copy link
Copy Markdown
Contributor Author

1Iv4N commented Sep 26, 2019

Hi @sfshaza2 I sent an email with the information. Thanks!

@sfshaza2
Copy link
Copy Markdown
Contributor

@maguinis, can you confirm that the company has signed an NDA?

@sfshaza2
Copy link
Copy Markdown
Contributor

@maguinis has confirmed that all involved have signed an NDA

@sfshaza2 sfshaza2 added cla: yes Contributor has signed the Contributor License Agreement and removed cla: no Contributor has not signed the Contributor License Agreement labels Sep 26, 2019
@googlebot
Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@sfshaza2
Copy link
Copy Markdown
Contributor

LGTM!

@sfshaza2 sfshaza2 merged commit 423f461 into flutter:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants