Conversation
googlebot
added
the
cla: yes
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
Hi Daniel! I have a few global comments that you might want to integrate before I continue reviewing.
Please break up all your lines to be 80 chars or less. It's hard to leave feedback on entire paragraphs. We often break the line on a phrase. Also, check with Kathy on the text in the "Check out Dart" text. More details are in the comments.
| Flutter supports devices that maintain right-to-left language settings. | ||
| {{site.alert.end}} | ||
| ## Introduction | ||
| In this codelab, you interact with and build Flutter layouts in a code editor called DartPad2. As you progress through this codelab, you learn that widgets build everything in flutter. A widget is an immutable object that describes a specific part of a UI. You also learn that, while widgets are simple in their functions, widgets can be complex in their structures. Widgets can be built around and inside of other widgets, and widgets can have interconnected and ordered relationships with one another. At the end of this codelab, you apply what you learn and build a simple interface using basic Fluter layout concepts. |
There was a problem hiding this comment.
For GitHub, we break our lines at 80 characters or less. So, please break this line (and the entire file) up.
There was a problem hiding this comment.
Going back to Sublime and breaking up the characters.
| Flutter supports devices that maintain right-to-left language settings. | ||
| {{site.alert.end}} | ||
| ## Introduction | ||
| In this codelab, you interact with and build Flutter layouts in a code editor called DartPad2. As you progress through this codelab, you learn that widgets build everything in flutter. A widget is an immutable object that describes a specific part of a UI. You also learn that, while widgets are simple in their functions, widgets can be complex in their structures. Widgets can be built around and inside of other widgets, and widgets can have interconnected and ordered relationships with one another. At the end of this codelab, you apply what you learn and build a simple interface using basic Fluter layout concepts. |
There was a problem hiding this comment.
In this case "will" is OK. Because they will be doing this. So:
In this coddelab, you'll interact with and build Flutter layouts...
=> At the end of this codelab, you'll apply...
Also, in this last sentence you misspell Flutter. (Fluter)
There was a problem hiding this comment.
Added future tenses and fixed typo; I also forgot to capitalize Flutter in one instance.
| {{site.alert.end}} | ||
| ## Introduction | ||
| In this codelab, you interact with and build Flutter layouts in a code editor called DartPad2. As you progress through this codelab, you learn that widgets build everything in flutter. A widget is an immutable object that describes a specific part of a UI. You also learn that, while widgets are simple in their functions, widgets can be complex in their structures. Widgets can be built around and inside of other widgets, and widgets can have interconnected and ordered relationships with one another. At the end of this codelab, you apply what you learn and build a simple interface using basic Fluter layout concepts. | ||
| ## Row class and Column class |
| ## Introduction | ||
| In this codelab, you interact with and build Flutter layouts in a code editor called DartPad2. As you progress through this codelab, you learn that widgets build everything in flutter. A widget is an immutable object that describes a specific part of a UI. You also learn that, while widgets are simple in their functions, widgets can be complex in their structures. Widgets can be built around and inside of other widgets, and widgets can have interconnected and ordered relationships with one another. At the end of this codelab, you apply what you learn and build a simple interface using basic Fluter layout concepts. | ||
| ## Row class and Column class | ||
| `Row` and `Column` are classes that contain widgets. When `Row` and `Column` contain widgets, the widgets become "children," and `Row` and `Column` become "parents." Moreover, when `Row` and `Column` contain widgets, `Row` and `Column` lay them out. `Row` lays out its widgets horizontally. `Column` lays out its widgets vertically. |
There was a problem hiding this comment.
Replace with:
`Row` and `Column` are classes that contain, and lay out, widgets.
These widgets are called "children" and `Row` and `Column` are referred to as "parents."
`Row` lays out..
| {:.no_toc} | ||
| {{site.alert.secondary}} | ||
| {:.no_toc} | ||
| *Check out Dart.* |
There was a problem hiding this comment.
GLOBAL: I think I'd use "Try Dart" instead of "Check out Dart", but see what Kathy thinks.
There was a problem hiding this comment.
Alright, I'll see what Kathy says.
| {:.no_toc} | ||
| *Check out Dart.* | ||
|
|
||
| In the code, `Row` contains three children, all `BlueBox` widgets. |
|
|
||
| In the code, `Row` contains three children, all `BlueBox` widgets. | ||
|
|
||
| In this code example, the code displays three blue squares horizontally. |
There was a problem hiding this comment.
=> The following example displays three blue squares horizontally/.
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
OK, I'm stopping here for now, but giving you a chance to address what I have so far..
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
This time I reviewed the whole thing. Please don't reply to my specific comments because it just clutters up the PR.
| {:.no_toc} | ||
| {{site.alert.secondary}} | ||
| {{site.alert.end}} | ||
|
|
kwalrath
left a comment
kwalrath
left a comment
There was a problem hiding this comment.
I stopped at line 473. I'll try to get you the remaining feedback tonight or tomorrow.
kwalrath
left a comment
kwalrath
left a comment
There was a problem hiding this comment.
I'd love to see some images in the last part, and some testing to make sure that everything works as planned.
This concludes my review. :) Note that I didn't closely look at the explanatory text (the non-exercise/example text before the "Putting it together" section). I can do that if you like, but I figured that Shams probably covered that well.
|
Related feedback from a recent issue: a user tried to copy the code in embedded Dartpad to full experimental playground but didn't know about the hidden test code. Takeaway: |
|
I'm not very clear about when you use light vs. dark theme. |
|
https://dt-flutter.firebaseapp.com (new hosting url, 08-18-2019) |
|
@datafoya The survey you included is designed for the Future codelab specifically so you can't use the same link. If needed, it should be a separate survey. |
|
@galeyang, deleted |
|
https://dt-flutter.firebaseapp.com/docs/codelabs/layout-basics (new hosting url, 08-20-2019) |
|
https://dt-flutter.firebaseapp.com/docs/codelabs/layout-basics (new hosting url, 08-21-2019) |
5 participants
Staged: https://dt-flutter.firebaseapp.com/docs/codelabs/extended-flex-widget
@Sfshaza
@kwalrath