Update the DevTools hash to the latest.#461
Closed
kenzieschmoll wants to merge 2 commits intomainfrom
Closed
Conversation
9 tasks
justinmc
approved these changes
Jun 24, 2025
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍 . Thanks for opening this PR! Hopefully it fixes flutter/flutter#170544.
Member
Author
|
@justinmc Looks like the checks are failing on the patrol customer tests, which I saw on flutter/flutter#170544 too. Have you already reached out to folks from leancode to address these tests? Should I send a separate PR to disable them while they are broken? |
Contributor
|
@kenzieschmoll I have not, thanks for noticing that. I'm about to be OOO for a week so no rush on my side. Maybe I can check in when I'm back and then disable them if they're still broken? |
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 14, 2025
The Patrol tests are failing due to a dependency error. I'm trying to bump the customer tests but can't because of this. See #461, which shows the failing tests. We definitely should re-enable these test once they're fixed! I'm just trying to get things moving along. From [this run](https://github.com/flutter/tests/actions/runs/15858365759/job/45589357091) I see: ``` >> flutter packages get | Resolving dependencies... | Because leancode_lint >=14.3.0 <14.4.0 depends on analyzer ^6.7.0 and analyzer >=6.6.0 <6.9.0 depends on macros >=0.1.2-main.3 <0.1.3, leancode_lint >=14.3.0 <14.4.0 requires macros >=0.1.2-main.3 <0.1.3 or analyzer ^6.9.0. | Because macros >=0.1.2-main.4 <0.1.3-main.0 depends on _macros 0.3.2 from sdk and macros >=0.1.2-main.2 <0.1.2-main.4 depends on _macros 0.3.1 from sdk, macros >=0.1.2-main.2 <0.1.3-main.0 requires _macros 0.3.1 or 0.3.2 from sdk. | Thus, leancode_lint >=14.3.0 <14.4.0 requires analyzer ^6.9.0 or _macros 0.3.1 or 0.3.2 from sdk. | And because leancode_lint >=14.4.0 <15.1.0 depends on analyzer ^6.11.0, leancode_lint >=14.3.0 <15.1.0 requires analyzer ^6.9.0 or _macros 0.3.1 or 0.3.2 from sdk. | And because analyzer >=6.9.0 <7.3.0 depends on macros >=0.1.3-main.0 <0.1.4 which depends on _macros 0.3.3 from sdk, leancode_lint >=14.3.0 <15.1.0 requires _macros 0.3.1 or 0.3.2 or 0.3.3 from sdk. | So, because _macros from sdk doesn't exist (could not find package _macros in the Dart SDK) and patrol_cli depends on leancode_lint ^14.3.0, version solving failed. | | | You can try the following suggestion to make the pubspec resolve: | * Try upgrading your constraint on leancode_lint: flutter pub add dev:leancode_lint:^17.0.0 | Failed to update packages. ERROR: Could not run "flutter pub get" in packages/patrol_cli, which was specified as an update directory. Deleting temporary directory... Contacts: piotr.denert@leancode.pl, piotr.maszota@leancode.pl, mateusz.wojtczak@leancode.pl, julia.borkowska@leancode.pl ```
Contributor
|
@kenzieschmoll Now that #462 is merged and devtools tests are disabled, I guess I no longer have a dependency on this PR for my work. Maybe once you all have fixed the devtools tests then this PR can be used to update to that new SHA. |
Member
Author
|
Closing this. @elliette will address flutter/flutter#172037 to re-enable the DevTools customer tests. |
Contributor
|
Sounds good, thanks for your help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.