[google_identity_services_web] - Enhance maybeEnum to handle if enum value is not exist with a return of null.#9006
Closed
Hamza-Nasser wants to merge 5 commits intoflutter:mainfrom
Closed
[google_identity_services_web] - Enhance maybeEnum to handle if enum value is not exist with a return of null.#9006Hamza-Nasser wants to merge 5 commits intoflutter:mainfrom
Hamza-Nasser wants to merge 5 commits intoflutter:mainfrom
Conversation
…rgumentError and add comprehensive tests
…theoretical test case for empty enum values
Member
|
Thanks for the fix! I would have landed this, but else beat you to the punch with this fix, here: #8999 (we should have assigned them the underlying issue, sorry!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old maybeEnum was throwing a transitive
ArgumentErrorthat is being thrown from the extension functionEnumByName::byNameif the string value does not match any, now it is returning null instead.This PR also have a new test file for the maybeEnum function with different test cases.
Fixes flutter/flutter#166548
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3