Skip to content

Remove usage of the env_variables property from .ci.yaml#11414

Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom
jason-simmons:remove_env_variables
Apr 2, 2026
Merged

Remove usage of the env_variables property from .ci.yaml#11414
auto-submit[bot] merged 1 commit intoflutter:mainfrom
jason-simmons:remove_env_variables

Conversation

@jason-simmons
Copy link
Copy Markdown
Member

@jason-simmons jason-simmons commented Apr 1, 2026

The LUCI recipes will now set the necessary environment variables based on the "channel" and "package_sharding" properties.

This was implemented in the recipes by https://flutter.googlesource.com/recipes/+/784cffbc698bf18e77d7fbe7b6fca6657f931135

The LUCI recipes will now set the necessary environment variables based on the "channel" and "package_sharding" properties.
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up the .ci.yaml configuration by removing redundant env_variables blocks across numerous CI targets for Linux, Web, Android, iOS, macOS, and Windows. These removed blocks previously duplicated values already specified in the channel and package_sharding properties. I have no feedback to provide as there are no review comments.

@jason-simmons jason-simmons added the CICD Run CI/CD label Apr 1, 2026
Copy link
Copy Markdown
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but for future archeologists (e.g., me when I'm trying to figure out this was supposed to work if a future recipe change breaks it) could you update the PR description to include a link to the relevant recipe change?

It's been long enough since this was all set up in the first place that I no longer remember why there were two ways of setting all of this in the first place.

@jason-simmons
Copy link
Copy Markdown
Member Author

LGTM, but for future archeologists (e.g., me when I'm trying to figure out this was supposed to work if a future recipe change breaks it) could you update the PR description to include a link to the relevant recipe change?

Done

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2026
@auto-submit auto-submit bot merged commit 66bf7ec into flutter:main Apr 2, 2026
82 checks passed
jason-simmons pushed a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2026
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Apr 2, 2026
flutter/packages@b3fcf14...66bf7ec

2026-04-02 jason-simmons@users.noreply.github.com Remove usage of the
env_variables property from .ci.yaml (flutter/packages#11414)
2026-04-02 engine-flutter-autoroll@skia.org Roll Flutter from
fb03253 to 3d69471 (69 revisions) (flutter/packages#11408)
2026-04-02 katelovett@google.com [two_dimensional_scrollables] Fix
merged cells unmerging behind pinned spans (flutter/packages#11418)
2026-04-02 jhy03261997@gmail.com [ci] Update reusable_release.yml to add
`--remote=origin` (flutter/packages#11413)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants