Skip to content

Update TabBar documentation to clarify indicatorWeight behavior #184104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
Mar 30, 2026
+5 −1
Merged

Update TabBar documentation to clarify indicatorWeight behavior #184104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/flutter/lib/src/material/tabs.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1000,7 +1000,11 @@ class TabBar extends StatefulWidget implements PreferredSizeWidget {
/// The [indicatorPadding] parameter defaults to [EdgeInsets.zero].
///
/// If [indicator] is not null or provided from [TabBarTheme],
/// then [indicatorWeight] and [indicatorColor] are ignored.
/// then [indicatorColor] is ignored.
///
/// The [indicatorWeight] does not affect the visual appearance of
/// the indicator when a custom [indicator] is provided. However,
/// it may still be used to compute the TabBar's preferred size.
Comment on lines +1003 to +1007
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This clarification improves the accuracy of the documentation by explaining that indicatorWeight is not entirely ignored when a custom indicator is provided, as it still contributes to the TabBar's preferredSize. This helps prevent potential misunderstandings for developers using custom indicators.

const TabBar({
super.key,
required this.tabs,
Expand Down