This code in the flutter/packages CI release step was added to fix a problem where the following section would run before any of the LUCI checks had checked in (especially when there was an incident causing slow webhooks), causing release to run before any of the tests. It's fixed that problem, but the same basic problem now manifests in a different way: sometimes the new code runs before Linux ci_yaml packages roller has checked in, causing the step to immediately fail.
This is a lot better than publishing plugins that haven't passed any tests, but it's now a flaky failure, which is not ideal since it then requires manual intervention to re-run to open the tree. Ideally what we want is a step that waits until that step both exits and completes, rather than failing if it's not there yet. I don't see a way to do that with the wait action we're using though, so we may well need to build our own replacement to get that behavior.
This code in the flutter/packages CI
releasestep was added to fix a problem where the following section would run before any of the LUCI checks had checked in (especially when there was an incident causing slow webhooks), causingreleaseto run before any of the tests. It's fixed that problem, but the same basic problem now manifests in a different way: sometimes the new code runs beforeLinux ci_yaml packages rollerhas checked in, causing the step to immediately fail.This is a lot better than publishing plugins that haven't passed any tests, but it's now a flaky failure, which is not ideal since it then requires manual intervention to re-run to open the tree. Ideally what we want is a step that waits until that step both exits and completes, rather than failing if it's not there yet. I don't see a way to do that with the wait action we're using though, so we may well need to build our own replacement to get that behavior.