Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fixes Objective-C objects memory leaks#14326

Merged
cbracken merged 6 commits intoflutter:masterfrom
zhongwuzw:fix_platform_oc_leaks
Dec 18, 2019
Merged

Fixes Objective-C objects memory leaks#14326
cbracken merged 6 commits intoflutter:masterfrom
zhongwuzw:fix_platform_oc_leaks

Conversation

@zhongwuzw
Copy link
Copy Markdown
Member

@zhongwuzw zhongwuzw commented Dec 11, 2019 •
edited by cyanglaz
Loading

Fixes CALayer memory leaks in file FlutterPlatformViews_Internal.mm,FlutterPlatformViews.mm

flutter/flutter#46750

@auto-assign auto-assign bot requested a review from franciscojma86 December 11, 2019 10:12
@zhongwuzw zhongwuzw mentioned this pull request Dec 11, 2019
Closed
chinmaygarde
chinmaygarde approved these changes Dec 11, 2019
View reviewed changes
shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm
auto contentsScale = flutter_view_.get().layer.contentsScale;
fml::scoped_nsobject<FlutterOverlayView> overlay_view(
[[[FlutterOverlayView alloc] initWithContentsScale:contentsScale] retain]);
[[FlutterOverlayView alloc] initWithContentsScale:contentsScale]);
Copy link
Copy Markdown
Contributor

@chinmaygarde chinmaygarde Dec 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@zhongwuzw
Copy link
Copy Markdown
Member Author

zhongwuzw commented Dec 12, 2019

@chinmaygarde Done.

cbracken
cbracken approved these changes Dec 16, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@cbracken
Copy link
Copy Markdown
Member

cbracken commented Dec 16, 2019

Waiting for the tree to go green before we merge.

@cbracken cbracken merged commit 9c1bd8a into flutter:master Dec 18, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
@engine-flutter-autoroll
9c1bd8a Fixes Objective-C objects memory leaks (flutter/engine#14326)
b88181f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
@engine-flutter-autoroll
9c1bd8a Fixes Objective-C objects memory leaks (flutter/engine#14326)
e87c517
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
@engine-flutter-autoroll
9c1bd8a Fixes Objective-C objects memory leaks (flutter/engine#14326)
a4ba3fe
This was referenced Dec 19, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
@engine-flutter-autoroll
9c1bd8a Fixes Objective-C objects memory leaks (flutter/engine#14326)
bee9b03
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
@engine-flutter-autoroll
9c1bd8a Fixes Objective-C objects memory leaks (flutter/engine#14326)
3c47cc8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
@engine-flutter-autoroll
9c1bd8a Fixes Objective-C objects memory leaks (flutter/engine#14326)
5d10e6f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
@engine-flutter-autoroll
9c1bd8a Fixes Objective-C objects memory leaks (flutter/engine#14326)
7a86814
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
@engine-flutter-autoroll
9c1bd8a Fixes Objective-C objects memory leaks (flutter/engine#14326)
f06b992
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
@engine-flutter-autoroll
9c1bd8a Fixes Objective-C objects memory leaks (flutter/engine#14326)
46a738a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
@engine-flutter-autoroll
9c1bd8a Fixes Objective-C objects memory leaks (flutter/engine#14326)
a1d5c51
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
@engine-flutter-autoroll
9c1bd8a Fixes Objective-C objects memory leaks (flutter/engine#14326)
cae129a
This was referenced Dec 19, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
@engine-flutter-autoroll
9c1bd8a Fixes Objective-C objects memory leaks (flutter/engine#14326)
2fb4f0f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
@engine-flutter-autoroll
9c1bd8a Fixes Objective-C objects memory leaks (flutter/engine#14326)
8cda8b9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 19, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
@engine-flutter-autoroll
9c1bd8a Fixes Objective-C objects memory leaks (flutter/engine#14326)
a215b20
This was referenced Dec 19, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
@engine-flutter-autoroll
9c1bd8a Fixes Objective-C objects memory leaks (flutter/engine#14326)
ed0e2d3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
@engine-flutter-autoroll
9c1bd8a Fixes Objective-C objects memory leaks (flutter/engine#14326)
514c226
This was referenced Dec 19, 2019
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2019
@engine-flutter-autoroll
9c1bd8a Fixes Objective-C objects memory leaks (flutter/engine#14326)
aa86bff
chingjun pushed a commit to flutter/flutter that referenced this pull request Dec 19, 2019
@engine-flutter-autoroll @chingjun
Roll engine 1e1f371..0f90e65 (14 commits) (#47429)
4af66e3 
* 988b8f1 Fix FontLoader does not remove the cache in web engine (flutter/engine#14536)

* 0aacac7 Roll src/third_party/skia 21df075cab00..e6a2ad81ab40 (1 commits) (flutter/engine#14552)

* 417dd7e Roll fuchsia/sdk/core/mac-amd64 from esDH2... to NHgyx... (flutter/engine#14554)

* f2e841d [Web] Fix pointer binding  (flutter/engine#14378)

* 105eb66 Roll src/third_party/skia e6a2ad81ab40..8fec4140f614 (17 commits) (flutter/engine#14557)

* 1ecfdcb [web] Calculate align offset for each paragraph line (LineMetrics.left) (flutter/engine#14537)

* dda3619 Roll src/third_party/dart 270966b16044..171059d27689 (19 commits) (flutter/engine#14558)

* 9c1bd8a Fixes Objective-C objects memory leaks (flutter/engine#14326)

* f2dbeb8 Reland Wire up Opacity on Fuchsia (flutter/engine#14559)

* 2f536e5 Roll fuchsia/sdk/core/linux-amd64 from jsuQq... to VdBKA... (flutter/engine#14560)

* 4312d37 Revert "[fuchsia] Add diagnostics directory to the set of remote dirs (#14470)" (flutter/engine#14566)

* 5c77ea1 Roll src/third_party/skia 8fec4140f614..9e0afb791ac2 (4 commits) (flutter/engine#14563)

* a09ff7c Roll src/third_party/dart 171059d27689..aa6709974dea (11 commits) (flutter/engine#14567)

* 0f90e65 Revert "[web] Calculate align offset for each paragraph line (LineMetrics.left) (#14537)" (flutter/engine#14569)
@shorben07 shorben07 mentioned this pull request Jan 9, 2020
Closed
@cyanglaz cyanglaz mentioned this pull request Jan 22, 2020
Closed
Partizann pushed a commit to Partizann/engine that referenced this pull request Mar 10, 2020
@zhongwuzw
Fixes Objective-C objects memory leaks (flutter#14326)
91c813b 
Fixes CALayer memory leaks in file FlutterPlatformViews_Internal.mm,FlutterPlatformViews.mm

flutter/flutter#46750
filmil pushed a commit to filmil/engine that referenced this pull request Mar 13, 2020
@zhongwuzw @filmil
Fixes Objective-C objects memory leaks (flutter#14326)
a11abf1 
Fixes CALayer memory leaks in file FlutterPlatformViews_Internal.mm,FlutterPlatformViews.mm

flutter/flutter#46750
@cyanglaz cyanglaz mentioned this pull request Apr 27, 2020
Closed
@liyuqian liyuqian added perf: memory Performance issues related to memory severe: performance Relates to speed or footprint issues. labels Jul 28, 2020
@joaovirgili
Copy link
Copy Markdown

joaovirgili commented Aug 14, 2020

is this already available on stable channel?

@mafreud mafreud mentioned this pull request Oct 22, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@franciscojma86 franciscojma86 Awaiting requested review from franciscojma86

2 more reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@cbracken cbracken cbracken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes perf: memory Performance issues related to memory severe: performance Relates to speed or footprint issues.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zhongwuzw @cbracken @joaovirgili @chinmaygarde @googlebot @liyuqian