Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Add comment on arm64_apilevel26 Android GN toolchain #761

Merged
zanderso merged 1 commit into from
Sep 5, 2023
Merged

Add comment on arm64_apilevel26 Android GN toolchain #761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions build/toolchain/android/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,10 @@ android_gcc_toolchains_helper("arm64") {
toolchain_cpu = "aarch64"
}

# This toolchain should only be used to build the target
# //third_party/vulkan_validation_layers. This is because vulkan validation
# layers requires API level >= 26, but Flutter officially supports down to API
# level 22, which is the default value of the android_api_level argument.
Copy link
Copy Markdown
Member

@gaaclarke gaaclarke Sep 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to mention something about how this is safe only because of runtime checks before loading the dynamic library

Copy link
Copy Markdown
Member Author

@zanderso zanderso Sep 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good point. Adding a comment to that effect in flutter/engine#45467.

android_gcc_toolchains_helper("arm64_apilevel26") {
android_ndk_lib_dir = arm64_android_lib

Expand Down