Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Add CODEOWNERS file#515

Merged
jmagman merged 1 commit intoflutter:masterfrom
jmagman:ios-codeowner
Oct 8, 2021
Merged

Add CODEOWNERS file#515
jmagman merged 1 commit intoflutter:masterfrom
jmagman:ios-codeowner

Conversation

@jmagman
Copy link
Copy Markdown
Member

@jmagman jmagman commented Oct 8, 2021

#509 caused App Store submission failures for Flutter customers and several g3 apps.

Create a CODEOWNERS file. Add myself to build/config/ios so I am automatically added to any reviews of this file so I get a heads up when these settings are changed. The codeowner is not a blocking reviewer, but is automatically added to any PRs that change the file.

$ git ls-files build/config/ios/
build/config/ios/BUILD.gn
build/config/ios/ios_sdk.gni
build/config/ios/ios_sdk.py

See also https://github.com/flutter/flutter/blob/master/CODEOWNERS.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@jmagman jmagman self-assigned this Oct 8, 2021
@jmagman jmagman requested a review from zanderso October 8, 2021 22:30
@jmagman
Copy link
Copy Markdown
Member Author

jmagman commented Oct 8, 2021

@zanderso how do I handle The base branch requires all commits to be signed. for a process PR like this one?

@zanderso
Copy link
Copy Markdown
Member

zanderso commented Oct 8, 2021

@Hixie may know.

@jmagman
Copy link
Copy Markdown
Member Author

jmagman commented Oct 8, 2021

Let me just sign the commit.

@Hixie
Copy link
Copy Markdown
Contributor

Hixie commented Oct 8, 2021

I can disable that if it's trouble, I enabled it for a bunch of repos as part of an audit but we may need to roll that particular one out with more documentation on how to actually sign commits.

@jmagman
Copy link
Copy Markdown
Member Author

jmagman commented Oct 8, 2021

I can disable that if it's trouble, I enabled it for a bunch of repos as part of an audit but we may need to roll that particular one out with more documentation on how to actually sign commits.

It took about 30 minutes but I figured it out on macOS...

@jmagman jmagman merged commit 9c1f9e9 into flutter:master Oct 8, 2021
@jmagman jmagman deleted the ios-codeowner branch October 8, 2021 23:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants