Consolidate namespace and file location

[vbreuss]

Fix ReSharper issue: "Namespace does not correspond to file location"

IMPORTANT

• If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
• The code complies with the Coding Guidelines for C#.
• The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
• If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
• If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
• If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

[coveralls]

Pull Request Test Coverage Report for Build 6835431454

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 97.444%

---

Totals
Change from base Build 6834887943:	0.0%
Covered Lines:	11741
Relevant Lines:	11926

---

💛 - Coveralls

[github-actions]

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

1. Register at Qodana Cloud and configure the action
2. Use GitHub Code Scanning with Qodana
3. Host Qodana report at GitHub Pages
4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.8
        with:
          upload-result: true

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[vbreuss]

@jnyrup :
I agree with your sentiment, that analyzers should be taken with a grain of salt, but they normally indicate a good spot to have a better look. If the decision is that the code is correct, I try to disable the analyzer in this case, so that it is clear that this was intentional.

I now moved the AssemblyAssertions class to the Types/ directory and adjusted the namespace accordingly.
Additionally I kept the namespace in the two polyfill classes SystemExtensions and StringBuilderExtensions and moved them to a separate directory. This way it is clear, that these are intended as polyfill and they can be excluded from analyzers.

[vbreuss]

@dennisdoomen : Do I have to do something more to merge the pull request?