Add v1 file format for MappedParallelComputationGraph and from_v1 conversion functions#1634
Open
elliottslaughter wants to merge 2 commits intoflexflow:masterfrom
Open
Add v1 file format for MappedParallelComputationGraph and from_v1 conversion functions#1634elliottslaughter wants to merge 2 commits intoflexflow:masterfrom
elliottslaughter wants to merge 2 commits intoflexflow:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two things:
V1MappedParallelComputationGraphfrom_v1conversion from v1 back to normal objectsWritten with Claude and manually inspected/cleaned. The only part I question is the
from_v1inlib/pcg/include/pcg/file_format/v1/graphs/v1_labelled_kwarg_dataflow_graph.h, but I've looked through the code and I don't see a more obvious way to do it, so maybe that's the best we can do. Otherwise the code is fairly obvious.This change is