Conversation
|
@spydon Any idea why the spell check lint is failing? |
|
FYI, the updated spineboy assets came from https://github.com/EsotericSoftware/spine-runtimes/tree/4.3-beta/spine-flutter/example/assets |
It's due to an update of the dictionary, so skel and antialiasing can be removed from our custom added words. |
|
Well, I updated it. I must admit that I am surprised because I didn't delete any documentation, and .skel files are definitely still a thing, but whatever. |
The general dictionary that we extend was updated to include those words, that's why we need to remove them from our custom add-ons. |
spydon
left a comment
spydon
left a comment
There was a problem hiding this comment.
Just one small comment, otherwise it looks good to me!
|
@spydon So, now it's mismatched in a few places. Do I need to drop it to 0.2.2 everywhere and the Melos release will update it in the tests/examples? |
Yes, Melos will bump it everywhere automatically. |
As-is, the existing `flame_spine` supports Spine 4.2. `spine_flutter` in 4.3.0 now supports Spine 4.3, and this is backwards incompatible and breaking. If you need Spine 4.2, you should not upgrade to `flame_spine` 0.3.0, but this is for anyone who is ready to make the Spine 4.3 jump. We recommend pinning to 0.2.2 for `spine_flutter` 4.2.36 if you are staying on Spine 4.2. The top-level API has many breaking changes, and this changelog has a good summary of what needs to be done: https://pub.dev/packages/spine_flutter/changelog The Dart code changes are relatively straightforward, but any Spine models need to be re-exported through the 4.3 Spine Editor (and you SHOULD make sure that all models still do everything that is expected! There might be random bones that don't look right any more, random animations, and certain models just don't work.) Dart API changes: https://pub.dev/packages/spine_flutter/changelog Re-export at 4.2 Spine models from the 4.3 Spine Editor and confirm each model works.
2 participants
Description
As-is, the existing
flame_spinesupports Spine 4.2.spine_flutterin 4.3.0 now supports Spine 4.3, and this is backwards incompatible and breaking. If you need Spine 4.2, you should not upgrade toflame_spine0.3.0, but this is for anyone who is ready to make the Spine 4.3 jump. We recommend pinning to 0.2.2 forspine_flutter4.2.36 if you are staying on Spine 4.2.The top-level API has many breaking changes, and this changelog has a good summary of what needs to be done: https://pub.dev/packages/spine_flutter/changelog
The Dart code changes are relatively straightforward, but any Spine models need to be re-exported through the 4.3 Spine Editor (and you SHOULD make sure that all models still do everything that is expected! There might be random bones that don't look right any more, random animations, and certain models just don't work.)
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Migration instructions
Dart API changes: https://pub.dev/packages/spine_flutter/changelog
Re-export at 4.2 Spine models from the 4.3 Spine Editor and confirm each model works.
Related Issues