refactor: Re-organize internal event imports#3742
Merged
Conversation
luanpotter
force-pushed
the
luan.events-organize
branch
from
743ccaf to
cb06bb4
Compare
spydon
reviewed
Oct 5, 2025
Member
spydon
left a comment
spydon
left a comment
There was a problem hiding this comment.
Hmm, events/messages isn't very clear, but events/events is confusing
Member
Author
|
Yeah I thought it was less bad. But I really wanted to change the first folder, and reclaim the name |
Member
Author
|
I just do the import fix for now - we can discuss the directory structre in the doc. |
luanpotter
force-pushed
the
luan.events-organize
branch
from
cb06bb4 to
e2111a7
Compare
luanpotter
changed the title
spydon
approved these changes
Oct 7, 2025
nickf2k
pushed a commit
to nickf2k/flame
that referenced
this pull request
Nov 16, 2025
Re-organize internal event files using the `events.dart` export. This changes the imports on all files to use the exposed `events.dart` export - this will vastly help us to catch issues of forgetting to expose things. If anything is imported from `src/`, we know it is not exposed by Flame. This should be absolutely no-op whatsoever - just organizational.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Re-organize internal event files using the
events.dartexport.This changes the imports on all files to use the exposed
events.dartexport - this will vastly help us to catch issues of forgetting to expose things. If anything is imported fromsrc/, we know it is not exposed by Flame.This should be absolutely no-op whatsoever - just organizational.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?