feat: Added fromCache method to AssetsCache#3740
Conversation
|
@spydon , hi please check if my implementation is good ?? |
spydon
left a comment
spydon
left a comment
There was a problem hiding this comment.
At least one test and potential docs need to be added.
| } | ||
|
|
||
| /// This method provides synchronous access to cached assets, similar to | ||
| /// [Images.fromCache]. |
There was a problem hiding this comment.
This is referring to the wrong file.
| /// [Images.fromCache]. | |
| /// [AssetsCache.fromCache]. |
i get these results when running melos run analyze, but while running tests i get errors saying Unable to load asset, The asset does not exist or has empty data. |
|
@sandy4242 analyze doesn't have anything to do with the tests. Push your test to the PR, it sounds like you haven't added the file to the cache before reading it. |
|
@spydon pushed it, why am i getting this as an error while running tests? |
Is there a file named |
|
@spydon here, yes and its contents are |
|
@sandy4242 then you probably have the path to the file wrong, so that it looks in the wrong directory for it. |
spydon
changed the title
|
@spydon hi, i did use alternative way to specify paths to find those assets but failed...so i asked ai to help me and its response was what should i do?? |
Pull request was closed
|
@spydon maybe yes i was pretty tensed about the asset's loading issue, so i asked ai to help, and i am so dumb not seeing the |
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com> Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
2 participants
Description
The pr adds the fromCache from the images class to the assetcache class
Checklist
Breaking Change?
Related Issues
Closes #3736