Skip to content

feat: Add flame_behaviors package#3717

Merged
spydon merged 41 commits intoflame-engine:mainfrom
omartinma:feat/flame_behaviors
Oct 6, 2025
Merged

feat: Add flame_behaviors package#3717
spydon merged 41 commits intoflame-engine:mainfrom
omartinma:feat/flame_behaviors

Conversation

@omartinma
Copy link
Copy Markdown
Contributor

@omartinma omartinma commented Sep 8, 2025 •
edited
Loading

Description

Moving flame_behaviors from VeryGoodOpenSource/flame_behaviors repository

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Relates to VeryGoodOpenSource/flame_behaviors#99

@spydon spydon changed the title feat: add flame_behaviors feat: Add flame_behaviors package Sep 8, 2025
@spydon
Copy link
Copy Markdown
Member

spydon commented Sep 17, 2025

@omartinma ping me when you want this reviewed :)

@omartinma omartinma marked this pull request as ready for review October 2, 2025 13:37
@omartinma
Copy link
Copy Markdown
Contributor Author

omartinma commented Oct 2, 2025

@spydon @erickzanardo this should be ready to review. Hopefully all will be good with the URLs once we merge, but please let me know if you spot any issue there.

Also, it is still pending to migrate https://github.com/VeryGoodOpenSource/flame_behaviors/tree/main/packages/flame_steering_behaviors. I was thinking to create another separate PR, but if you prefer we can merge all at once

erickzanardo
erickzanardo approved these changes Oct 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small nits but overall LGTM! Will wait for Lukas' review

Comment thread packages/flame_behaviors/example/LICENSE Outdated
Comment thread packages/flame_behaviors/lib/flame_behaviors.dart Outdated
Comment thread packages/flame_behaviors/pubspec.yaml Outdated
omartinma and others added 3 commits October 2, 2025 16:06
@omartinma @erickzanardo
Update packages/flame_behaviors/lib/flame_behaviors.dart
d2a1b6b 
Co-authored-by: Erick <erickzanardoo@gmail.com>
@omartinma @erickzanardo
Update packages/flame_behaviors/pubspec.yaml
72b2d5a 
Co-authored-by: Erick <erickzanardoo@gmail.com>
@omartinma @erickzanardo
Update packages/flame_behaviors/example/LICENSE
1acc573 
Co-authored-by: Erick <erickzanardoo@gmail.com>
@omartinma
Copy link
Copy Markdown
Contributor Author

omartinma commented Oct 2, 2025

A couple of small nits but overall LGTM! Will wait for Lukas' review

Just committed your suggestions! I will wait for @spydon :) Thanks both!

spydon
spydon reviewed Oct 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments, overall it looks good!

Comment thread doc/bridge_packages/flame_behaviors/collision-detection.md
Comment thread doc/bridge_packages/flame_behaviors/conventions/coding-conventions.md Outdated
Comment thread doc/bridge_packages/flame_behaviors/conventions/naming-conventions.md Outdated
Comment thread doc/bridge_packages/flame_behaviors/getting-started.md Outdated
Comment thread packages/flame_behaviors/.gitignore Outdated
Comment thread packages/flame_behaviors/example/analysis_options.yaml Outdated
Comment thread packages/flame_behaviors/test/src/behaviors/behavior_test.dart Outdated
Comment thread packages/flame_behaviors/test/src/behaviors/propagating_collision_behavior_test.dart Outdated
Comment thread packages/flame_behaviors/test/src/entity_test.dart Outdated
Comment thread packages/flame_behaviors/tool/release_ready.sh Outdated
omartinma and others added 9 commits October 6, 2025 13:44
@omartinma
Copy link
Copy Markdown
Contributor Author

omartinma commented Oct 6, 2025

@erickzanardo @spydon i just went trough all the comments, please let me know if there is anything else.

Also just to confirm on my message above, do you prefer separated PRs for https://github.com/VeryGoodOpenSource/flame_behaviors/tree/main/packages/flame_steering_behaviors or concatenate somehow?

spydon
spydon approved these changes Oct 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks @omartinma!
Let's do the steering behaviours separately.

@spydon spydon merged commit e950d79 into flame-engine:main Oct 6, 2025
9 checks passed
nickf2k pushed a commit to nickf2k/flame that referenced this pull request Nov 16, 2025
@omartinma @erickzanardo
@spydon @vuong3-nguyen
feat: Add flame_behaviors package (flame-engine#3717)
b28c5c9 
Moving flame_behaviors from [VeryGoodOpenSource/flame_behaviors
repository](https://github.com/VeryGoodOpenSource/flame_behaviors)

---------

Co-authored-by: Erick <erickzanardoo@gmail.com>
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spydon spydon spydon approved these changes

@erickzanardo erickzanardo erickzanardo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@omartinma @spydon @erickzanardo