fix: Take into consideration when child is added to parent that is removed in the same tick#3428
Merged
fix: Take into consideration when child is added to parent that is removed in the same tick#3428
Conversation
erickzanardo
approved these changes
Dec 30, 2024
nickf2k
pushed a commit
to nickf2k/flame
that referenced
this pull request
Nov 16, 2025
…moved in the same tick (flame-engine#3428) Currently we end up in a bad state if a child is added to a parent that is removed in the same tick, this PR fixes that by adding the child after the parent has been unmounted. Closes: flame-engine#3416
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently we end up in a bad state if a child is added to a parent that is removed in the same tick, this PR fixes that by adding the child after the parent has been unmounted.
Closes: #3416
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues