feat: Add support for strike-through text for flame_markdown#3426
Merged
luanpotter merged 1 commit intomainfrom Dec 29, 2024
Merged
feat: Add support for strike-through text for flame_markdown#3426luanpotter merged 1 commit intomainfrom
luanpotter merged 1 commit intomainfrom
Conversation
luanpotter
force-pushed
the
luan.strike
branch
2 times, most recently
from
22b3147 to
bd03bc7
Compare
luanpotter
force-pushed
the
luan.strike
branch
from
bd03bc7 to
2509490
Compare
Member
Author
|
Note: according to Wikipedia, "Strikethrough" is correct as a single word so I added to the dictionary but happy to rename everything to "Strike Through" if that is preferred. |
luanpotter
commented
Dec 29, 2024
| flame_markdown: ^0.2.2+3 | ||
| flutter: | ||
| sdk: flutter | ||
| markdown: ^7.1.1 |
Member
Author
There was a problem hiding this comment.
note: in order to provide custom documents, a user would need to add this as a direct dependency. another option is that we export all the relevant classes on flame_markdown; not sure what would be the best practice here
Member
There was a problem hiding this comment.
If there aren't that many I think we should export them
Member
Author
There was a problem hiding this comment.
let me make a followup as a proposal and we can assess together - sadly I think there is quite a few
spydon
approved these changes
Dec 29, 2024
nickf2k
pushed a commit
to nickf2k/flame
that referenced
this pull request
Nov 16, 2025
…ngine#3426) Add support for strike-through text for flame_markdown, if enabled by the user. Basically parses the `del` HTMl tag and maps it to a new inline text renderer in Flame's text rendering pipeline. The style can be controlled with a new property if desired. In order to parse `~~`-wrapped text into the new node element, the underlying markdown parser must have the strikethrough option enabled (or an equivalent custom option), which can be controlled by the user if providing their own document.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for strike-through text for flame_markdown, if enabled by the user.
Basically parses the
delHTMl tag and maps it to a new inline text renderer in Flame's text rendering pipeline.The style can be controlled with a new property if desired.
In order to parse
~~-wrapped text into the new node element, the underlying markdown parser must have the strikethrough option enabled (or an equivalent custom option), which can be controlled by the user if providing their own document.Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?