Skip to content

fix: Do not encode HTML by default when parsing markdown [flame_markdown]#3425

Merged
luanpotter merged 1 commit intomainfrom
luan.markdown
Dec 27, 2024
Merged

fix: Do not encode HTML by default when parsing markdown [flame_markdown]#3425
luanpotter merged 1 commit intomainfrom
luan.markdown

Conversation

@luanpotter
Copy link
Copy Markdown
Member

@luanpotter luanpotter commented Dec 26, 2024

Description

Do not encode HTML by default when parsing markdown [flame_markdown].

The Flame text rendering pipeline is not configured to accept HTML encoded sequences, therefore the default behaviour of Flame Markdown doesn't lead to a good result:

image

With this change:

image

Of the user can still override it as before.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@luanpotter luanpotter requested a review from spydon December 26, 2024 22:04
@luanpotter luanpotter merged commit 3067da9 into main Dec 27, 2024
@luanpotter luanpotter deleted the luan.markdown branch December 27, 2024 06:37
nickf2k pushed a commit to nickf2k/flame that referenced this pull request Nov 16, 2025
…own] (flame-engine#3425)

Do not encode HTML by default when parsing markdown [flame_markdown].

The Flame text rendering pipeline is not configured to accept HTML
encoded sequences, therefore the default behaviour of Flame Markdown
doesn't lead to a good result:


![image](https://github.com/user-attachments/assets/b8463c88-1b2c-475e-ab23-9eb56864d518)

With this change:


![image](https://github.com/user-attachments/assets/85c94c0c-019f-4b55-b713-a995ccef1361)

Of the user can still override it as before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants