feat: Warning and docs about fullscreen methods outside the mobile platforms#3419
Merged
erickzanardo merged 6 commits intomainfrom Dec 19, 2024
Merged
feat: Warning and docs about fullscreen methods outside the mobile platforms#3419erickzanardo merged 6 commits intomainfrom
erickzanardo merged 6 commits intomainfrom
Conversation
spydon
reviewed
Dec 19, 2024
spydon
approved these changes
Dec 19, 2024
Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
nickf2k
pushed a commit
to nickf2k/flame
that referenced
this pull request
Nov 16, 2025
…atforms (flame-engine#3419) Adds a warning when calling `fullScreen` and the new added method `restoreFullscreen` when used in a desktop platform. Also adds a brief warning to the docs about some methods in the device class not working outside mobile --------- Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a warning when calling
fullScreenand the new added methodrestoreFullscreenwhen used in a desktop platform.Also adds a brief warning to the docs about some methods in the device class not working outside mobile
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues