Merged
Conversation
sedan07
commented
Feb 10, 2021
sedan07
commented
- 2.3 does not have the ability to make component groups visible only to authenticated users. So defaulting to making component groups public so your existing component groups don't suddenly disappear from your public status page when updating.
- 2.3 does not have a completed_at time for maintenance so when migrated to 2.5 they all appear as still open (i.e in progress) and so show up on the status page, not very nice if you have lots of these and have been using Cachet for many years. So closing all maintenance schedules which were meant to start over a day ago. This should mean any in progress now won't get closed automatically before their time.
Otherwise all maintenance schedules will appear on the status page, if you have 10s or 100s of these closing them won't be much fun.
graemedavidson
approved these changes
Feb 10, 2021
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.