Ignore modal styles "swal2" when purging unused CSS #20#27
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.5 #27 +/- ##
============================================
+ Coverage 55.88% 55.92% +0.04%
Complexity 1264 1264
============================================
Files 275 275
Lines 4803 4803
============================================
+ Hits 2684 2686 +2
+ Misses 2119 2117 -2
Continue to review full report at Codecov.
|
graemedavidson
approved these changes
Feb 8, 2021
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CSS for the modal window was missing as it gets added dynamically to the HTML. Ignoring anything prefixed with
swal2-when purging unused styles seems to solve the issue.