Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase#184
Closed
carusogabriel wants to merge 2 commits intofirebase:masterfrom
carusogabriel:patch-1
Closed
Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase#184carusogabriel wants to merge 2 commits intofirebase:masterfrom carusogabriel:patch-1
carusogabriel wants to merge 2 commits intofirebase:masterfrom
carusogabriel:patch-1
Conversation
Collaborator
|
Closing in favor of #193 because we updated the build files and rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use the
PHPUnit\Framework\TestCasenotation instead ofPHPUnit_Framework_TestCasewhile extending our TestCases. This will help us migrate to PHPUnit 6, that no longer support snake case class names.Just needed to bump PHPUnit version to
4.8.36, to keep compatibility.Also, changed
Travis CIto run thePHPUnitversion installed withComposer, not the globally one. The global one is in version~6.4, and contains some deprecated method that we'll need to work on that latter.