feat(js/plugins/google-genai): Support for googleai multimodal embedder#4905
feat(js/plugins/google-genai): Support for googleai multimodal embedder#4905
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the GoogleAI plugin by integrating support for multimodal embedding, enabling the processing of content that combines text and various media types. The changes involve extending the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for the Google AI multimodal embedder, specifically gemini-embedding-2-preview. Key changes include adding a fromParts static method to the Document class, updating the embedder.ts to recognize the new multimodal model and handle its configuration, and modifying the EmbedContentRequest to correctly convert document content into the Gemini message format with a 'user' role. The changes also include necessary type updates for embedder model names and comprehensive test cases for the new multimodal embedding functionality. The updates to various test and sample applications to use gemini-embedding-001 for text embedding are also appropriate. Overall, the changes are well-implemented and directly support the stated objective of adding multimodal embedding capabilities.
Checklist (if applicable):