feat: redesign 404 page with error image and fix GitHub Pages routing#810
Open
feat: redesign 404 page with error image and fix GitHub Pages routing#810
Conversation
…ting Add error illustration and visual improvements to all three language versions of the 404 page. Replace the Hugo alias-based 404.html (which landed under /en/404.html due to defaultContentLanguageInSubdir) with a static/404.html that reliably serves from the root on GitHub Pages. Fixes #717 Fixes #136
|
Hi there! 👋 Thank you for your contribution to the FIP Guide! 🚀 Checklist before merging:
|
lenderom
requested review from
MoritzWeber0 and
therobrob
and removed request for
therobrob
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
therobrob
reviewed
Apr 5, 2026
| } | ||
|
|
||
| &--center > figure { | ||
| float: none; |
Member
There was a problem hiding this comment.
So the class .m-float-image—center doesn’t contain any floating? Is this the correct use of BEM?
| --- | ||
|
|
||
| Hoppla! Die gesuchte Seite ist nicht verfügbar oder wurde verschoben. | ||
| {{% float-image |
Member
There was a problem hiding this comment.
Do we have to use the float-image partial here or could we use the normal image partial instead? :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
error.webp) and improved layout usingfloat-imageandintersectorshortcodes across all three languages (en, de, fr)404.html(which incorrectly landed under/en/404.htmldue todefaultContentLanguageInSubdir: true) with astatic/404.htmlthat reliably serves from the site rootcenterposition support forfloat-imagein SCSSFixes #717
Fixes #136