refactor: Replace icon font with SVG icons #790
+76
−83
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
| font-size: 1.3rem; | ||
| } | ||
|
|
||
| .o-last-updated > .a-icon { | ||
| font-size: 1.5rem; | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,6 +45,10 @@ | |
| gap: 2rem; | ||
| margin-bottom: 2rem; | ||
|
|
||
| @media (max-width: #{$breakpoint-xl}) { | ||
| grid-template-columns: 1fr 1fr 1fr 1fr 2fr; | ||
| } | ||
|
|
||
| @media (max-width: #{$breakpoint-lg}) { | ||
| display: flex; | ||
| gap: 1rem; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -79,12 +79,12 @@ a, | |
| text-decoration: none; | ||
| color: var(--bs-body-color); | ||
|
|
||
| > .a-icon { | ||
| display: none; | ||
| } | ||
| } | ||
|
|
||
| & > .a-icon { | ||
| margin: 0 0.2rem; | ||
| } | ||
| } | ||
|
|
@@ -205,10 +205,6 @@ figure { | |
| } | ||
| } | ||
|
|
||
| .o-list__list { | ||
| display: grid; | ||
| grid-template-columns: repeat(auto-fit, minmax(260px, 1fr)); | ||
|
|
@@ -439,7 +435,7 @@ details > summary { | |
|
|
||
| .o-link__mail, | ||
| .o-link__tel { | ||
| & > .a-icon { | ||
| margin-right: 0.4rem; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,8 +23,8 @@ | |
|
|
||
| @include focus-indicator(0.3rem); | ||
|
|
||
| .a-icon { | ||
| font-size: 2rem; | ||
| margin-top: 1rem; | ||
| } | ||
|
|
||
|
|
@@ -110,7 +110,7 @@ | |
| flex-direction: column; | ||
| justify-content: space-between; | ||
|
|
||
| > .a-icon { | ||
| @media print { | ||
| display: none; | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,6 +30,8 @@ module: | |
| target: "static" | ||
| - source: "node_modules/@fontsource" | ||
| target: "static/css/@fontsource" | ||
| - source: "node_modules/@material-symbols/svg-700/rounded" | ||
| target: "static/icons/material-symbols-rounded" | ||
|
|
||
| related: | ||
| includeNewer: true | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,8 +10,7 @@ | |
| <item> | ||
| <title>{{ .Title }}</title> | ||
| <link>{{ .Permalink }}</link> | ||
| {{ $cleanedHTML := .Summary | plainify | transform.XMLEscape | safeHTML }} | ||
| <description>{{ $cleanedHTML }}</description> | ||
| <pubDate>{{ .PublishDate.Format "Mon, 02 Jan 2006 15:04:05 -0700" | safeHTML }}</pubDate> | ||
| <enclosure url="{{ (partial "helper/contentImage" . ).Permalink }}" /> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,9 +15,9 @@ <h3 id="o-related__title">{{ T "news.further" }}</h3> | |
| ) | ||
| }} | ||
| {{ if eq .Page.Type "news" }} | ||
| <span class="o-related__date"> | ||
| {{ .Date | time.Format ":date_long" }} | ||
| </span> | ||
| {{ end }} | ||
| </li> | ||
| {{ end }} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,9 @@ | ||
| <span | ||
| data-pagefind-ignore="all" | ||
| class="a-icon" | ||
| translate="no" | ||
| aria-hidden="true" | ||
| data-icon="{{ . }}" | ||
| style="--icon-url: url('/icons/material-symbols-rounded/{{ . }}.svg');" | ||
| ></span> | ||
| {{- /* Needed, otherwise links break: https://github.com/fipguide/fipguide.github.io/issues/116 */ -}} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,7 @@ <h3 class="m-teaser__headline">{{ $page.Title }}</h3> | |
|
|
||
|
|
||
| <div class="m-teaser__text"> | ||
| {{ $page.Summary | plainify | truncate 500 }} | ||
| </div> | ||
| {{- partial "icon" "arrow_forward" -}} | ||
| </div> | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the icon is smaller than before, it should be 20x20px
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the general size increase, it's now 17x17 vs 18x18 on my side. I do think it looks slightly better with the alignment:
Before:
After:
If you like the previous icon more, I can increase the font-size to 1.25em, then it's ~18px on my side again.