feat: add password reset for default admin/user accounts#1463
Closed
jescalada wants to merge 6 commits intofinos:mainfrom
Closed
feat: add password reset for default admin/user accounts#1463jescalada wants to merge 6 commits intofinos:mainfrom
jescalada wants to merge 6 commits intofinos:mainfrom
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1463 +/- ##
==========================================
- Coverage 89.66% 89.22% -0.45%
==========================================
Files 68 69 +1
Lines 4869 5020 +151
Branches 888 921 +33
==========================================
+ Hits 4366 4479 +113
- Misses 485 522 +37
- Partials 18 19 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Tests were failing due to a race condition when regenerating the session, fixed altogether by logging out instead
Contributor
Author
|
Closing, decided not to implement regeneration/logout. Original PR is ready for review #1457 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR for #1022, attempting to debug failing E2E tests from #1457